Re: [BUG] error compiling qemu-kvm-0.15.0 without vnc

Jan Kiszka
2011-08-31T07:40:37Z

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

On 2011-08-31 02:03, Chris Friesen wrote:
> Hi,
>
> I've run into another problem. I configured qemu-kvm-0.15.0 as:
>
> ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl --disable-vnc --disable-curses
>
>
> Building it, I get:
>
> CC i386-softmmu/pcspk.o
> CC i386-softmmu/i8254.o
> CC i386-softmmu/i8254-kvm.o
> CC i386-softmmu/device-assignment.o
> LINK i386-softmmu/qemu
> monitor.o: In function `add_graphics_client':
> /home/cfriesen/Download/qemu-kvm-0.15.0/monitor.c:1226: undefined reference to `vnc_display_add_client'
> collect2: ld returned 1 exit status
> make[1]: *** [qemu] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
>
> The following patch allowed it to compile, but I don't know enough about kvm to know if this is the proper thing to do.
>
> Chris
>
>
>
> Index: cfriesen/Download/qemu-kvm-0.15.0/console.h
> ===================================================================
> --- cfriesen.orig/Download/qemu-kvm-0.15.0/console.h
> +++ cfriesen/Download/qemu-kvm-0.15.0/console.h
> @@ -372,15 +372,18 @@ void cocoa_display_init(DisplayState *ds
> void vnc_display_init(DisplayState *ds);
> void vnc_display_close(DisplayState *ds);
> int vnc_display_open(DisplayState *ds, const char *display);
> -void vnc_display_add_client(DisplayState *ds, int csock, int skipauth);
> int vnc_display_disable_login(DisplayState *ds);
> char *vnc_display_local_addr(DisplayState *ds);
> #ifdef CONFIG_VNC
> +void vnc_display_add_client(DisplayState *ds, int csock, int skipauth);
> int vnc_display_password(DisplayState *ds, const char *password);
> int vnc_display_pw_expire(DisplayState *ds, time_t expires);
> void do_info_vnc_print(Monitor *mon, const QObject *data);
> void do_info_vnc(Monitor *mon, QObject **ret_data);
> #else
> +static inline void vnc_display_add_client(DisplayState *ds, int csock, int skipauth)
> +{
> +}
> static inline int vnc_display_password(DisplayState *ds, const char *password)
> {
> qerror_report(QERR_FEATURE_DISABLED, "vnc");
>
>
>

c62f6d1d76aea587556c85b6b7b5c44167006264 and
860341f60582959698d2e1d839a5b7a004a2d76f need to be applied to
stable-0.15 of upstream QEMU.

Jan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]