From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH] KVM: PPC: e500: Don't hardcode PIR=0
Date: Fri, 2 Sep 2011 13:14:55 -0500
Message-ID: <4E611D1F.9010409@freescale.com>
References: <20110901230851.GA26220@schlenkerla.am.freescale.net> <9E450E07-D406-4666-AE9C-F879944EDDB8@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: "<kvm-ppc@vger.kernel.org>" <kvm-ppc@vger.kernel.org>,
	"<kvm@vger.kernel.org>" <kvm@vger.kernel.org>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <9E450E07-D406-4666-AE9C-F879944EDDB8@suse.de>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 09/02/2011 10:12 AM, Alexander Graf wrote:
> 
> Am 02.09.2011 um 01:08 schrieb Scott Wood <scottwood@freescale.com>:
> 
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
> 
> Patch description missing.

It's not missing, it's just brief. :-)

I suppose you could add "The hardcoded behavior prevents SMP support.
QEMU shall specify the vcpu's PIR as the vcpu id".

> Also, since pir == vcpu_id now, can't we just remove pir?

>>From sregs?  Is that worth the compatibility breakage?  We could define
a new bit for ARCH206 without PIR, but older QEMU would then not see the
other ARCH206 stuff.

-Scott