From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4 v9] MSI-X MMIO support for KVM Date: Tue, 06 Sep 2011 10:52:41 +0300 Message-ID: <4E65D149.1070807@redhat.com> References: <1298019193-12742-1-git-send-email-sheng@linux.intel.com> <20110222180858.GA5784@amt.cnet> <4E5F6C20.7020701@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, "Michael S. Tsirkin" , Alex Williamson To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60275 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753369Ab1IFHwq (ORCPT ); Tue, 6 Sep 2011 03:52:46 -0400 In-Reply-To: <4E5F6C20.7020701@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/01/2011 02:27 PM, Jan Kiszka wrote: > On 2011-02-22 19:08, Marcelo Tosatti wrote: > > On Fri, Feb 18, 2011 at 04:53:09PM +0800, Sheng Yang wrote: > >> Sorry for the long delay, just come back from vacation... > >> > >> Change from v8: > >> 1. Update struct kvm_run to contain MSI-X routing update exit specific > >> information. > >> 2. Fix a mmio_nr counting bug. > >> > >> Notice this patchset still based on 2.6.37 due to a block bug on assigned > >> device in the upstream now. > >> > >> Sheng Yang (4): > >> KVM: Move struct kvm_io_device to kvm_host.h > >> KVM: Add kvm_io_ext_data to IO handler > >> KVM: Emulate MSI-X table in kernel > >> KVM: Add documents for MSI-X MMIO API > > > > Looks good to me. > > What happened to this series and [1]? Forgotten because Sheng switched > his job? I actually have guilty feelings about it now and then. It's just hard to merge such a complicated change with a non-trivial userspace interface. > I just realized that MSI-X per-vector masking for assigned devices is > not only slow (takes user space exits) but just simply broken (masking > bit is not evaluated and applied to the device). Isn't that just a bug in qemu? Or something else? > > BTW, the same is also true for that optional per-vector masking of > legacy MSI. Are there devices in the field that actually support this? I > haven't found one so far and tend to consider this feature not worth > implementing. Don't know. I don't like implementing features on the basis of bug reports, though. On the other hand we can't really test it without a real device. > > Jan > > [1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/68144 > -- error compiling committee.c: too many arguments to function