From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH 4/5] VFIO: Add PCI device support Date: Thu, 08 Sep 2011 10:52:19 +0300 Message-ID: <4E687433.9020204@redhat.com> References: <20110901194915.2391.97400.stgit@s20.home> <20110901195050.2391.12028.stgit@s20.home> <20110907185505.GF7074@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: aafabbri@cisco.com, aik@au1.ibm.com, kvm@vger.kernel.org, pmac@au1.ibm.com, qemu-devel@nongnu.org, joerg.roedel@amd.com, agraf@suse.de, iommu@lists.linux-foundation.org, dwg@au1.ibm.com, chrisw@sous-sol.org, B08248@freescale.com, Alex Williamson , linux-pci@vger.kernel.org, B07421@freescale.com, benve@cisco.com To: Konrad Rzeszutek Wilk Return-path: In-Reply-To: <20110907185505.GF7074@dumpdata.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 09/07/2011 09:55 PM, Konrad Rzeszutek Wilk wrote: > > If you don't know what to do here, say N. > > + > > +menuconfig VFIO_PCI > > + bool "VFIO support for PCI devices" > > + depends on VFIO&& PCI > > + default y if X86 > > Hahah.. And Linus is going to tear your behind for that. > > Default should be 'n' It depends on VFIO, which presumably defaults to n. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.