From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v3 05/11] KVM: MMU: do not mark accessed bit on pte write path Date: Wed, 14 Sep 2011 02:29:43 +0800 Message-ID: <4E6FA117.1050707@cn.fujitsu.com> References: <4E5C4C20.3000403@cn.fujitsu.com> <4E5C4C8D.5040509@cn.fujitsu.com> <4E6F363E.9080000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM To: Avi Kivity Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:60266 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932095Ab1IMS1O (ORCPT ); Tue, 13 Sep 2011 14:27:14 -0400 In-Reply-To: <4E6F363E.9080000@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/13/2011 06:53 PM, Avi Kivity wrote: > On 08/30/2011 05:35 AM, Xiao Guangrong wrote: >> In current code, the accessed bit is always set when page fault occurred, >> do not need to set it on pte write path > > What about speculative sptes that are then only accessed via emulation? > The gfn is read and written only via emulation? I think this case is very very rare?