From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH v3 03/11] KVM: x86: retry non-page-table writing instruction
Date: Wed, 14 Sep 2011 18:19:39 +0800
Message-ID: <4E707FBB.5030809@cn.fujitsu.com>
References: <4E5C4C20.3000403@cn.fujitsu.com> <4E5C4C5C.8030602@cn.fujitsu.com> <4E6F34CF.1060302@redhat.com> <4E6F9FD2.4010407@cn.fujitsu.com> <4E707991.10705@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:54057 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1756215Ab1INKRL (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 14 Sep 2011 06:17:11 -0400
In-Reply-To: <4E707991.10705@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 09/14/2011 05:53 PM, Avi Kivity wrote:
> On 09/13/2011 09:24 PM, Xiao Guangrong wrote:
>> >>
>> >>  +static bool retry_instruction(struct x86_emulate_ctxt *ctxt,
>> >>  +                  unsigned long cr2,  int emulation_type)
>> >>  +{
>> >>  +    if (!vcpu->arch.mmu.direct_map&&   !mmu_is_nested(vcpu))
>> >>  +        gpa = kvm_mmu_gva_to_gpa_write(vcpu, cr2, NULL);
>> >
>> >  If mmu_is_nested() cr2 is an ngpa, we have to translate it to a gpa, no?
>> >
>>
>> Yeah, will fix it.
>>
>> And this bug also exists in the current code: it always uses L2 gpa to emulate
>> write operation.
> 
> Can you please send this fix separately, so it can be backported if needed?
> 

Sure, i will do it as soon as possible. :-)