From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 03/14] KVM: x86 emulator: move memop, memopp into emulation context
Date: Wed, 14 Sep 2011 18:25:21 +0300 [thread overview]
Message-ID: <4E70C761.4020201@redhat.com> (raw)
In-Reply-To: <20110915002144.feb1139e.takuya.yoshikawa@gmail.com>
On 09/14/2011 06:21 PM, Takuya Yoshikawa wrote:
> >
> > Nothing should be accessed from outside the emulator, except via
> > accessors. We should move initialization to the emulator as well (or
> > just initialize from x86_decode_insn() - any reason not to?)
>
> Not big reason but kvm_inject_realmode_interrupt() and kvm_task_switch()
> call emulate_int_real() and emulator_task_switch() respectively without
> doing generic decoding.
>
> So at least, we need some special initialization for them if we move
> init_emulate_ctxt() into x86_decode_insn().
>
Best if x86_decode_insn(), emulate_int_real(), and
emulator_task_switch() all call an internal initialization function.
This way the external caller doesn't have to worry about the details.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-09-14 15:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 7:45 [PATCH 00/14] Emulator decode generalization Avi Kivity
2011-09-13 7:45 ` [PATCH 01/14] KVM: x86 emulator: fix Src2CL decode Avi Kivity
2011-09-13 7:45 ` [PATCH 02/14] KVM: x86 emulator: convert group 3 instructions to direct decode Avi Kivity
2011-09-13 7:45 ` [PATCH 03/14] KVM: x86 emulator: move memop, memopp into emulation context Avi Kivity
2011-09-14 10:41 ` Takuya Yoshikawa
2011-09-14 11:37 ` Avi Kivity
2011-09-14 15:21 ` Takuya Yoshikawa
2011-09-14 15:25 ` Avi Kivity [this message]
2011-09-13 7:45 ` [PATCH 04/14] KVM: x86 emulator: split dst decode to a generic decode_operand() Avi Kivity
2011-09-13 7:45 ` [PATCH 05/14] KVM: x86 emulator: expand decode flags to 64 bits Avi Kivity
2011-09-13 7:45 ` [PATCH 06/14] KVM: x86 emulator: switch src2 to generic decode_operand() Avi Kivity
2011-09-13 7:45 ` [PATCH 07/14] KVM: x86 emulator: free up some flag bits near src, dst Avi Kivity
2011-09-13 7:45 ` [PATCH 08/14] KVM: x86 emulator: switch OpImmUByte decode to decode_imm() Avi Kivity
2011-09-13 7:45 ` [PATCH 09/14] KVM: x86 emulator: qualify OpReg inhibit_byte_regs hack Avi Kivity
2011-09-13 7:45 ` [PATCH 10/14] KVM: x86 emulator: switch src decode to decode_operand() Avi Kivity
2011-09-13 7:45 ` [PATCH 11/14] KVM: x86 emulator: simplify OpMem64 decode Avi Kivity
2011-09-13 7:45 ` [PATCH 12/14] KVM: x86 emulator: streamline decode of segment registers Avi Kivity
2011-09-13 7:45 ` [PATCH 13/14] KVM: x86 emulator: switch lds/les/lss/lfs/lgs to direct decode Avi Kivity
2011-09-13 7:45 ` [PATCH 14/14] KVM: x86 emulator: convert push %sreg/pop %sreg " Avi Kivity
2011-09-14 11:12 ` [PATCH 00/14] Emulator decode generalization Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E70C761.4020201@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).