* RFC: s390: extension capability for new address space layout
@ 2011-09-20 11:56 Christian Borntraeger
2011-09-20 12:00 ` Alexander Graf
2011-09-20 12:11 ` Avi Kivity
0 siblings, 2 replies; 5+ messages in thread
From: Christian Borntraeger @ 2011-09-20 11:56 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti
Cc: Alexander Graf, Heiko Carstens, Carsten Otte, KVM list,
Martin Schwidefsky
Avi,Marcelo,
598841ca9919d008b520114d8a4378c4ce4e40a1 ([S390] use gmap address
spaces for kvm guest images) changed kvm on s390 to use a separate
address space for kvm guests. We can now put KVM guests anywhere
in the user address mode with a size up to 8PB - as long as the
memory is 1MB-aligned. This change was done without KVM extension
capability bit.
The change was added after 3.0, but we still have a chance to add
a feature bit before 3.1 (keeping the releases in a sane state).
Can you have a look at the change below and give you ACK or NACK?
If ok, I would push this patch to Heiko to be submitted via the
s390 stream for 3.1.
Christian
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -123,6 +123,7 @@ int kvm_dev_ioctl_check_extension(long ext)
switch (ext) {
case KVM_CAP_S390_PSW:
+ case KVM_CAP_S390_GMAP:
r = 1;
break;
default:
diff --git a/include/linux/kvm.h b/include/linux/kvm.h
index 2c366b5..b2e9cc1 100644
--- a/include/linux/kvm.h
+++ b/include/linux/kvm.h
@@ -553,6 +553,7 @@ struct kvm_ppc_pvinfo {
#define KVM_CAP_SPAPR_TCE 63
#define KVM_CAP_PPC_SMT 64
#define KVM_CAP_PPC_RMA 65
+#define KVM_CAP_S390_GMAP 66
#ifdef KVM_CAP_IRQ_ROUTING
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: RFC: s390: extension capability for new address space layout
2011-09-20 11:56 RFC: s390: extension capability for new address space layout Christian Borntraeger
@ 2011-09-20 12:00 ` Alexander Graf
2011-09-20 12:10 ` Christian Borntraeger
2011-09-20 12:11 ` Avi Kivity
1 sibling, 1 reply; 5+ messages in thread
From: Alexander Graf @ 2011-09-20 12:00 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Avi Kivity, Marcelo Tosatti, Heiko Carstens, Carsten Otte,
KVM list, Martin Schwidefsky
On 09/20/2011 01:56 PM, Christian Borntraeger wrote:
> Avi,Marcelo,
>
> 598841ca9919d008b520114d8a4378c4ce4e40a1 ([S390] use gmap address
> spaces for kvm guest images) changed kvm on s390 to use a separate
> address space for kvm guests. We can now put KVM guests anywhere
> in the user address mode with a size up to 8PB - as long as the
> memory is 1MB-aligned. This change was done without KVM extension
> capability bit.
> The change was added after 3.0, but we still have a chance to add
> a feature bit before 3.1 (keeping the releases in a sane state).
>
> Can you have a look at the change below and give you ACK or NACK?
> If ok, I would push this patch to Heiko to be submitted via the
> s390 stream for 3.1.
>
> Christian
>
> Signed-off-by: Christian Borntraeger<borntraeger@de.ibm.com>
>
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -123,6 +123,7 @@ int kvm_dev_ioctl_check_extension(long ext)
>
> switch (ext) {
> case KVM_CAP_S390_PSW:
> + case KVM_CAP_S390_GMAP:
> r = 1;
> break;
> default:
> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index 2c366b5..b2e9cc1 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -553,6 +553,7 @@ struct kvm_ppc_pvinfo {
> #define KVM_CAP_SPAPR_TCE 63
> #define KVM_CAP_PPC_SMT 64
> #define KVM_CAP_PPC_RMA 65
> +#define KVM_CAP_S390_GMAP 66
I would really appreciate if you could take capability number 71. I
already have patches pending (partly already in avi's tree) that occupy
everything up to 70 :)
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: RFC: s390: extension capability for new address space layout
2011-09-20 12:00 ` Alexander Graf
@ 2011-09-20 12:10 ` Christian Borntraeger
0 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2011-09-20 12:10 UTC (permalink / raw)
To: Alexander Graf
Cc: Avi Kivity, Marcelo Tosatti, Heiko Carstens, Carsten Otte,
KVM list, Martin Schwidefsky
On 20/09/11 14:00, Alexander Graf wrote:
>> +#define KVM_CAP_S390_GMAP 66
>
> I would really appreciate if you could take capability number 71. I already have patches pending (partly already in avi's tree) that occupy everything up to 70 :)
Whatever number is best for you all. Just waiting for Avi or Marcelo to ACK.
Christian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: RFC: s390: extension capability for new address space layout
2011-09-20 11:56 RFC: s390: extension capability for new address space layout Christian Borntraeger
2011-09-20 12:00 ` Alexander Graf
@ 2011-09-20 12:11 ` Avi Kivity
2011-09-20 14:31 ` Carsten Otte
1 sibling, 1 reply; 5+ messages in thread
From: Avi Kivity @ 2011-09-20 12:11 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Marcelo Tosatti, Alexander Graf, Heiko Carstens, Carsten Otte,
KVM list, Martin Schwidefsky
On 09/20/2011 02:56 PM, Christian Borntraeger wrote:
> Avi,Marcelo,
>
> 598841ca9919d008b520114d8a4378c4ce4e40a1 ([S390] use gmap address
> spaces for kvm guest images) changed kvm on s390 to use a separate
> address space for kvm guests. We can now put KVM guests anywhere
> in the user address mode with a size up to 8PB - as long as the
> memory is 1MB-aligned. This change was done without KVM extension
> capability bit.
> The change was added after 3.0, but we still have a chance to add
> a feature bit before 3.1 (keeping the releases in a sane state).
>
> Can you have a look at the change below and give you ACK or NACK?
> If ok, I would push this patch to Heiko to be submitted via the
> s390 stream for 3.1.
ACK, with Alex's changes. Why are kvm changes not going in through the
kvm tree? Or at least kvm@ review?
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: RFC: s390: extension capability for new address space layout
2011-09-20 12:11 ` Avi Kivity
@ 2011-09-20 14:31 ` Carsten Otte
0 siblings, 0 replies; 5+ messages in thread
From: Carsten Otte @ 2011-09-20 14:31 UTC (permalink / raw)
To: Avi Kivity
Cc: borntrae, Marcelo Tosatti, Alexander Graf, heicars2, KVM list,
mschwid2
On 20.09.2011 14:11, Avi Kivity wrote:
> ACK, with Alex's changes. Why are kvm changes not going in through the
> kvm tree? Or at least kvm@ review?
It slipped through as I've put it into our CVS to test against Martin's
changes. Sorry about that, we'll make sure it won't happen again.
so long,
Carsten
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-09-20 12:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-20 11:56 RFC: s390: extension capability for new address space layout Christian Borntraeger
2011-09-20 12:00 ` Alexander Graf
2011-09-20 12:10 ` Christian Borntraeger
2011-09-20 12:11 ` Avi Kivity
2011-09-20 14:31 ` Carsten Otte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox