From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2] KVM: Fix simultaneous NMIs
Date: Tue, 20 Sep 2011 20:28:03 +0300 [thread overview]
Message-ID: <4E78CD23.5000705@redhat.com> (raw)
In-Reply-To: <20110920163021.GA29618@amt.cnet>
On 09/20/2011 07:30 PM, Marcelo Tosatti wrote:
> > >
> > >> We do have a small issue. If we exit during NMI-blocked-by-STI and
> > >> nmi_pending == 2, then we lose the second interrupt. Should rarely
> > >> happen, since external interrupts never exit in that condition, but
> > >> it's a wart.
> > >
> > >And the above system reset case, you should be able to handle it by
> > >saving/restoring nmi_queued (so that QEMU can zero it in vcpu_reset).
> >
> > We could just add a KVM_CAP (and flag) that extends nmi_pending from
> > a bool to a counter.
>
> Or just add a new field to the pad.
>
Okay; I'll address this in a follow-on patch (my preference is making
nmi_pending a counter).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-09-20 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 10:43 [PATCH v2] KVM: Fix simultaneous NMIs Avi Kivity
2011-09-20 13:25 ` Marcelo Tosatti
2011-09-20 13:56 ` Avi Kivity
2011-09-20 14:59 ` Marcelo Tosatti
2011-09-20 16:24 ` Avi Kivity
2011-09-20 16:30 ` Marcelo Tosatti
2011-09-20 17:28 ` Avi Kivity [this message]
2011-09-21 8:46 ` Avi Kivity
2011-09-21 16:44 ` Marcelo Tosatti
2011-09-23 11:54 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E78CD23.5000705@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox