kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Lukas Doktor <ldoktor@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org,
	kvm-autotest@redhat.com, akong@redhat.com, jzupka@redhat.com
Subject: Re: [KVM-autotest][PATCH] cgroup test with KVM guest +first subtests
Date: Fri, 23 Sep 2011 10:36:50 -0300	[thread overview]
Message-ID: <4E7C8B72.20404@redhat.com> (raw)
In-Reply-To: <1316708986-12045-1-git-send-email-ldoktor@redhat.com>

On 09/22/2011 01:29 PM, Lukas Doktor wrote:
> Hi guys,
>
> Do you remember the discussion about cgroup testing in autotest vs. LTP? I hope there won't be any doubts about this one as ground_test (+ first 2 subtests) are strictly focused on cgroups features enforced on KVM guest systems. Also more subtests will follow if you approve the test structure (blkio_throttle, memory, cpus...).

Yes, absolutely.

>
> No matter whether we drop or keep the general 'cgroup' test. The 'cgroup_common.py' library can be imported either from 'client/tests/cgroup/' directory or directly from 'client/tests/kvm/tests/' directory.

I don't think we really need to drop the test. It's useful anyway, even 
though there are LTP tests that sort of cover ir.

>
> The modifications of 'cgroup_common.py' library is backward compatible with general cgroup test.
>
> See the commits for details.

Now that we moved to github, I'd like to go with the following model of 
contribution:

1) You create a user on github if you don't have one
2) Create a public autotest fork
3) Commit the changes to a topic branch appropriately named
4) Make a pull request to autotest:master
5) You still send the patches to the mailing list normally, but mention 
the pull request URL on the message.

That's it, we are still trying out things, so if this doesn't work out, 
we'll update the process. Is it possible that you do that and rebase 
your patches?

Oh, and since patchwork is still out due to DNS outage, could you guys 
re-spin your client-server patches using the same process I mentioned? 
Thank you!

Lucas

  parent reply	other threads:[~2011-09-23 13:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22 16:29 [KVM-autotest][PATCH] cgroup test with KVM guest +first subtests Lukas Doktor
2011-09-22 16:29 ` [PATCH 1/2] cgroup: cgroup_common.py bugfixies and modifications Lukas Doktor
2011-09-23  8:54   ` Jiri Zupka
2011-09-22 16:29 ` [PATCH 2/2] adds cgroup tests on KVM guests with first test Lukas Doktor
2011-09-23  8:54   ` Jiri Zupka
2011-11-03  6:04   ` Suqin
2011-11-03  7:32     ` Lukáš Doktor
2011-09-23 13:36 ` Lucas Meneghel Rodrigues [this message]
2011-09-23 15:02   ` [KVM-autotest][PATCH] cgroup test with KVM guest +first subtests Lukáš Doktor
2011-09-23 17:41     ` Lucas Meneghel Rodrigues
2011-09-27 18:23 ` Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E7C8B72.20404@redhat.com \
    --to=lmr@redhat.com \
    --cc=akong@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=jzupka@redhat.com \
    --cc=kvm-autotest@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=ldoktor@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).