From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu: Fix inject-nmi Date: Mon, 26 Sep 2011 11:21:13 +0300 Message-ID: <4E8035F9.9080908@redhat.com> References: <20110913093835.GB4265@localhost.localdomain> <20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com> <4E705BC3.5000508@cn.fujitsu.com> <20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com> <4E71B28F.7030201@cn.fujitsu.com> <4E72F3BA.2000603@jp.fujitsu.com> <4E73200A.7040908@jp.fujitsu.com> <4E76C6AA.9080403@cn.fujitsu.com> <4E7B04DC.1030407@cn.fujitsu.com> <4E7B4B8F.507@siemens.com> <4E7C51E4.2000503@cn.fujitsu.com> <4E7F3585.40108@redhat.com> <4E7F635E.6080009@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Lai Jiangshan , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" , KAMEZAWA Hiroyuki , Kenji Kaneshige To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37165 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975Ab1IZIVX (ORCPT ); Mon, 26 Sep 2011 04:21:23 -0400 In-Reply-To: <4E7F635E.6080009@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 09/25/2011 08:22 PM, Jan Kiszka wrote: > On 2011-09-25 16:07, Avi Kivity wrote: > > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: > >> > Moreover: wrong indention. > >> > > >> > You know that this won't work for qemu-kvm with in-kernel irqchip? You > >> > may want to provide a patch for that tree, emulating the unavailable > >> > LINT1 injection via testing the APIC configration and then raising an > >> > NMI as before if it is accepted. > >> > > >> > >> It works in my box but the NMI is not injected through the in-kernel > >> irqchip, > >> I will implement it as you suggested. > > > > Somewhat hacky; isn't it better to test LINT1 in the kernel (and > > redefine the KVM_NMI ioctl as "toggle LINT1")? > > KVM_NMI is required for user space IRQ chip as well. We could define KVM_NMI as edging the core NMI input if !irqchip_in_kernel, and toggling LINT1 otherwise. Hardly nice though. The current KVM_NMI with irqchip_in_kernel is not meaningful, since it doesn't obey the rules of any NMI source. > Introducing some KVM_SET_LINT1 is an option though. But emulating it for > the NMI button on older kernels sounds worthwhile nevertheless. > Perhaps this is the best option to avoid confusion. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.