From mboxrd@z Thu Jan 1 00:00:00 1970 From: Asias He Subject: Re: [PATCH v2] kvm tools: Support multiple net devices Date: Mon, 26 Sep 2011 20:22:37 +0800 Message-ID: <4E806E8D.70800@gmail.com> References: <1316949085-22598-1-git-send-email-levinsasha928@gmail.com> <4E8068C7.7080009@gmail.com> <1317038379.4465.2.camel@lappy> <4E806BF3.8030601@gmail.com> <1317039271.4465.4.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: penberg@cs.helsinki.fi, kvm@vger.kernel.org, mingo@elte.hu, gorcunov@gmail.com To: Sasha Levin Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:39649 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753205Ab1IZMXO (ORCPT ); Mon, 26 Sep 2011 08:23:14 -0400 Received: by ywb5 with SMTP id 5so4211191ywb.19 for ; Mon, 26 Sep 2011 05:23:13 -0700 (PDT) In-Reply-To: <1317039271.4465.4.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On 09/26/2011 08:14 PM, Sasha Levin wrote: > On Mon, 2011-09-26 at 20:11 +0800, Asias He wrote: >> On 09/26/2011 07:59 PM, Sasha Levin wrote: >>> On Mon, 2011-09-26 at 19:57 +0800, Asias He wrote: >>>> On 09/25/2011 07:11 PM, Sasha Levin wrote: >>>>> This patch adds support for multiple network devices. The command >>>> line syntax >>>>> changes to the following: >>>>> >>>>> --network/-n [mode=[tap/user/none]] [guest_ip=[guest ip]] >>>> [host_ip= >>>>> [host_ip]] [guest_mac=[guest_mac]] [script=[script]] >>>> >>>> This syntax is actually, no? >>>> >>>> --network/-n mode=tap,guest_ip=x.x.x.x >>>> >>>> not >>>> >>>> --network/-n mode=tag guest_ip=x.x.x.x >>>> >>>> >>>> This works for me: >>>> $ sudo ./kvm run -d sid.img -p root=/dev/vda1 -k bzImage \ >>>> -n mode=tap,host_ip=192.168.100.1 -n mode=tap,host_ip=192.168.200.1 >>>> >>>> This does not work for me: >>>> $ sudo ./kvm run -d sid.img -p root=/dev/vda1 -k bzImage \ >>>> -n mode=tap host_ip=192.168.100.1 -n mode=tap host_ip=192.168.200.1 >>> >>> Yes, with ',' ofcourse :) >> >> Sasha, Can you drop these []? There are way too many []. Although [] >> tells user this option is optional. >> >> --network/-n [mode=[tap/user/none]] [guest_ip=[guest ip]] [host_ip= >> [host_ip]] [guest_mac=[guest_mac]] [script=[script]] >> >> >> Does this look ok? >> --network/-n >> mode=tap|user|none,guest_ip=x.x.x.x,host_ip=x.x.x.x,guest_mac=xx:xx:xx:xx:xx:xx,script=script.sh > > We really need them to specify they are optional. > > How about this: > > --network/-n > [mode=tap/user/none][,guest_ip=ip][,host_ip=ip][,guest_mac=mac][,script=file] OK. -- Asias He