From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH] virt.virt_env_process: Abstract screenshot production Date: Mon, 26 Sep 2011 10:10:39 -0300 Message-ID: <4E8079CF.6000508@redhat.com> References: <1316820461-14259-1-git-send-email-lmr@redhat.com> <4E806FB6.1050301@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, mjenner@redhat.com To: =?ISO-8859-2?Q?Luk=E1=B9_Doktor?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63969 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750Ab1IZNKl (ORCPT ); Mon, 26 Sep 2011 09:10:41 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8QDAfxT007808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Sep 2011 09:10:41 -0400 In-Reply-To: <4E806FB6.1050301@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/26/2011 09:27 AM, Luk=E1=B9 Doktor wrote: > Hi, > > vm.screendump() doesn't have parameter 'debug'. My fault, the screendump method on both qmp and human monitors does tak= e=20 this parameter, and since the implementation on virt_env_process was=20 using the monitor method directly, I forgot to add the param to screend= ump. It's fixed now. debug=3DTrue by default, the only place where it is Fal= se=20 is during screendump thread (to avoid polluting the logs). https://github.com/autotest/autotest/commit/49b1d9b65ab0061aaf631c19620= 987bc59592af6 > So you should either add debug parameter to kvm_vm.py or remove this > parameter (and perhaps add debug=3DFalse into kvm_vm.py). > > Regards, > Luk=E1=B9 > > > Dne 24.9.2011 01:27, Lucas Meneghel Rodrigues napsal(a): >> In order to ease work with other virtualization types, >> make virt_env_process to call vm.screendump() instead >> of vm.monitor.screendump(). >> >> Signed-off-by: Lucas Meneghel Rodrigues >> --- >> client/virt/virt_env_process.py | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/client/virt/virt_env_process.py >> b/client/virt/virt_env_process.py >> index 789fa01..9999a2e 100644 >> --- a/client/virt/virt_env_process.py >> +++ b/client/virt/virt_env_process.py >> @@ -110,7 +110,7 @@ def preprocess_vm(test, params, env, name): >> scrdump_filename =3D os.path.join(test.debugdir, "pre_%s.ppm" % name= ) >> try: >> if vm.monitor and params.get("take_regular_screendumps") =3D=3D "yes= ": >> - vm.monitor.screendump(scrdump_filename, debug=3DFalse) >> + vm.screendump(scrdump_filename, debug=3DFalse) >> except kvm_monitor.MonitorError, e: >> logging.warn(e) >> >> @@ -151,7 +151,7 @@ def postprocess_vm(test, params, env, name): >> scrdump_filename =3D os.path.join(test.debugdir, "post_%s.ppm" % nam= e) >> try: >> if vm.monitor and params.get("take_regular_screenshots") =3D=3D "yes= ": >> - vm.monitor.screendump(scrdump_filename, debug=3DFalse) >> + vm.screendump(scrdump_filename, debug=3DFalse) >> except kvm_monitor.MonitorError, e: >> logging.warn(e) >> >> @@ -460,7 +460,7 @@ def _take_screendumps(test, params, env): >> if not vm.is_alive(): >> continue >> try: >> - vm.monitor.screendump(filename=3Dtemp_filename, debug=3DFalse) >> + vm.screendump(filename=3Dtemp_filename, debug=3DFalse) >> except kvm_monitor.MonitorError, e: >> logging.warn(e) >> continue >