Re: [PATCH] virt.virt_env_process: Abstract screenshot production

[Lucas Meneghel Rodrigues <lmr@redhat.com>]

On 09/26/2011 10:20 AM, Lukáš Doktor wrote:
> Dne 26.9.2011 15:10, Lucas Meneghel Rodrigues napsal(a):
>> On 09/26/2011 09:27 AM, Lukáš Doktor wrote:
>>> Hi,
>>>
>>> vm.screendump() doesn't have parameter 'debug'.
>>
>> My fault, the screendump method on both qmp and human monitors does
>> take this parameter, and since the implementation on virt_env_process
>> was using the monitor method directly, I forgot to add the param to
>> screendump.
>>
>> It's fixed now. debug=True by default, the only place where it is
>> False is during screendump thread (to avoid polluting the logs).
>>
>> https://github.com/autotest/autotest/commit/49b1d9b65ab0061aaf631c19620987bc59592af6
>>
> We used the same fix ;-)

Yup :) Now, please rebase your topic branch, remove the fix and commit 
it with push --force. The pull request will be updated automatically, I 
will test it here and will let you know if there are more comments 
before I merge it with upstream.