From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH] virt.virt_env_process: Abstract screenshot production Date: Mon, 26 Sep 2011 10:28:08 -0300 Message-ID: <4E807DE8.1080201@redhat.com> References: <1316820461-14259-1-git-send-email-lmr@redhat.com> <4E806FB6.1050301@redhat.com> <4E8079CF.6000508@redhat.com> <4E807C26.7060101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, mjenner@redhat.com To: =?ISO-8859-2?Q?Luk=E1=B9_Doktor?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19150 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781Ab1IZN2K (ORCPT ); Mon, 26 Sep 2011 09:28:10 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8QDSAME013242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Sep 2011 09:28:10 -0400 In-Reply-To: <4E807C26.7060101@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/26/2011 10:20 AM, Luk=E1=B9 Doktor wrote: > Dne 26.9.2011 15:10, Lucas Meneghel Rodrigues napsal(a): >> On 09/26/2011 09:27 AM, Luk=E1=B9 Doktor wrote: >>> Hi, >>> >>> vm.screendump() doesn't have parameter 'debug'. >> >> My fault, the screendump method on both qmp and human monitors does >> take this parameter, and since the implementation on virt_env_proces= s >> was using the monitor method directly, I forgot to add the param to >> screendump. >> >> It's fixed now. debug=3DTrue by default, the only place where it is >> False is during screendump thread (to avoid polluting the logs). >> >> https://github.com/autotest/autotest/commit/49b1d9b65ab0061aaf631c19= 620987bc59592af6 >> > We used the same fix ;-) Yup :) Now, please rebase your topic branch, remove the fix and commit=20 it with push --force. The pull request will be updated automatically, I= =20 will test it here and will let you know if there are more comments=20 before I merge it with upstream.