From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: qemu-kvm: Remaining relevant bits in kvm/ Date: Thu, 29 Sep 2011 19:42:26 +0200 Message-ID: <4E84AE02.6040104@siemens.com> References: <4E8337D5.4050301@siemens.com> <20110929171004.GB4986@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm To: Marcelo Tosatti Return-path: Received: from thoth.sbs.de ([192.35.17.2]:19884 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754171Ab1I2Rmb (ORCPT ); Thu, 29 Sep 2011 13:42:31 -0400 In-Reply-To: <20110929171004.GB4986@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-09-29 19:10, Marcelo Tosatti wrote: > On Wed, Sep 28, 2011 at 05:05:57PM +0200, Jan Kiszka wrote: >> Hi all, >> >> in order to reduce the diff between qemu-kvm.git and upstream, >> getting rid of the kvm subdirectory would be nice. What bits there >> are actually still in use today? >> >> From the top of my head, I only remember running kvm_stat and >> scripts/vmxcap from time to time. Obviously, there is nothing >> actively built anymore during normal qemu production. So what is the >> role of, e.g., >> >> - kvm/bios > > Does not exist. Indeed. Dunno why I saw this. > >> - kvm/extboot >> - kvm/vgabios > > Not needed, pc-bios/ version used instead. > >> - kvm/scripts >> >> today? Anything there we want to push upstream? And then drop the rest? > > Keep kvm_stat and scripts/ (other than vmxcap the *-release are still > used), as far as i'm concerned. I don't want to keep things there. I want to push useful stuff upstream and remove the rest. Alternatively, qemu-kvm specific release helpers could be kept private in the top-level scripts/ of qemu-kvm. My suggestion: - kvm/kvm_stat -> qemu.git/scripts/kvm/kvm_stat - kvm/scripts/vmxcap -> qemu.git/scripts/kvm/vmxcap - kvm/scripts/*-release-> qemu-kvm.git/scripts - rm -r kvm Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux