* Re: linux-next: Tree for Sept 29 (kvm)
[not found] <20110929165730.661cf28c9bb27b8a85432cd2@canb.auug.org.au>
@ 2011-09-29 19:50 ` Randy Dunlap
2011-09-29 22:58 ` Stephen Rothwell
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2011-09-29 19:50 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, kvm@vger.kernel.org
On 09/28/11 23:57, Stephen Rothwell wrote:
> Hi all,
>
> The linux-next tree is now available from
> git://github.com/sfrothwell/linux-next.git as a temporary measure while
> the kernel.org servers are unavailable.
kvm build on i386 says:
ERROR: "__udivdi3" [arch/x86/kvm/kvm.ko] undefined!
which is used in somewhere in start_apic_timer() (probably the divide :).
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Sept 29 (kvm)
2011-09-29 19:50 ` linux-next: Tree for Sept 29 (kvm) Randy Dunlap
@ 2011-09-29 22:58 ` Stephen Rothwell
2011-09-30 11:50 ` [PATCH] KVM: x86: Use do_div for tsc deadline calculation Jan Kiszka
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2011-09-29 22:58 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-next, LKML, kvm@vger.kernel.org, Avi Kivity,
Marcelo Tosatti
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
[Just cc'ing the kvm guys ]
On Thu, 29 Sep 2011 12:50:24 -0700 Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> On 09/28/11 23:57, Stephen Rothwell wrote:
> > Hi all,
> >
> > The linux-next tree is now available from
> > git://github.com/sfrothwell/linux-next.git as a temporary measure while
> > the kernel.org servers are unavailable.
>
>
> kvm build on i386 says:
>
> ERROR: "__udivdi3" [arch/x86/kvm/kvm.ko] undefined!
>
> which is used in somewhere in start_apic_timer() (probably the divide :).
>
>
> --
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] KVM: x86: Use do_div for tsc deadline calculation
2011-09-29 22:58 ` Stephen Rothwell
@ 2011-09-30 11:50 ` Jan Kiszka
2011-09-30 17:35 ` Randy Dunlap
2011-10-02 9:05 ` Avi Kivity
0 siblings, 2 replies; 5+ messages in thread
From: Jan Kiszka @ 2011-09-30 11:50 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti
Cc: Stephen Rothwell, Randy Dunlap, linux-next, LKML,
kvm@vger.kernel.org, Liu >> "Liu, Jinsong",
Tian, Kevin
Required on i386 hosts.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
arch/x86/kvm/lapic.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index f9385ec..92390dc 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -740,9 +740,10 @@ static void start_apic_timer(struct kvm_lapic *apic)
now = apic->lapic_timer.timer.base->get_time();
guest_tsc = kvm_x86_ops->read_l1_tsc(vcpu);
- if (likely(tscdeadline > guest_tsc))
- ns = (tscdeadline - guest_tsc)
- * 1000000L / this_tsc_khz;
+ if (likely(tscdeadline > guest_tsc)) {
+ ns = (tscdeadline - guest_tsc) * 1000000ULL;
+ do_div(ns, this_tsc_khz);
+ }
hrtimer_start(&apic->lapic_timer.timer,
ktime_add_ns(now, ns), HRTIMER_MODE_ABS);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: x86: Use do_div for tsc deadline calculation
2011-09-30 11:50 ` [PATCH] KVM: x86: Use do_div for tsc deadline calculation Jan Kiszka
@ 2011-09-30 17:35 ` Randy Dunlap
2011-10-02 9:05 ` Avi Kivity
1 sibling, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2011-09-30 17:35 UTC (permalink / raw)
To: Jan Kiszka
Cc: Avi Kivity, Marcelo Tosatti, Stephen Rothwell, linux-next, LKML,
kvm@vger.kernel.org, Liu >> "Liu, Jinsong",
Tian, Kevin
On 09/30/11 04:50, Jan Kiszka wrote:
> Required on i386 hosts.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> arch/x86/kvm/lapic.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index f9385ec..92390dc 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -740,9 +740,10 @@ static void start_apic_timer(struct kvm_lapic *apic)
>
> now = apic->lapic_timer.timer.base->get_time();
> guest_tsc = kvm_x86_ops->read_l1_tsc(vcpu);
> - if (likely(tscdeadline > guest_tsc))
> - ns = (tscdeadline - guest_tsc)
> - * 1000000L / this_tsc_khz;
> + if (likely(tscdeadline > guest_tsc)) {
> + ns = (tscdeadline - guest_tsc) * 1000000ULL;
> + do_div(ns, this_tsc_khz);
> + }
> hrtimer_start(&apic->lapic_timer.timer,
> ktime_add_ns(now, ns), HRTIMER_MODE_ABS);
>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] KVM: x86: Use do_div for tsc deadline calculation
2011-09-30 11:50 ` [PATCH] KVM: x86: Use do_div for tsc deadline calculation Jan Kiszka
2011-09-30 17:35 ` Randy Dunlap
@ 2011-10-02 9:05 ` Avi Kivity
1 sibling, 0 replies; 5+ messages in thread
From: Avi Kivity @ 2011-10-02 9:05 UTC (permalink / raw)
To: Jan Kiszka
Cc: Marcelo Tosatti, Stephen Rothwell, Randy Dunlap, linux-next, LKML,
kvm@vger.kernel.org, Liu >> "Liu, Jinsong",
Tian, Kevin
On 09/30/2011 02:50 PM, Jan Kiszka wrote:
> Required on i386 hosts.
>
>
Thanks, applied.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-02 9:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110929165730.661cf28c9bb27b8a85432cd2@canb.auug.org.au>
2011-09-29 19:50 ` linux-next: Tree for Sept 29 (kvm) Randy Dunlap
2011-09-29 22:58 ` Stephen Rothwell
2011-09-30 11:50 ` [PATCH] KVM: x86: Use do_div for tsc deadline calculation Jan Kiszka
2011-09-30 17:35 ` Randy Dunlap
2011-10-02 9:05 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).