qemu-kvm: Remaining relevant bits in kvm/

qemu-kvm: Remaining relevant bits in kvm/

[Jan Kiszka]

Hi all,

in order to reduce the diff between qemu-kvm.git and upstream, getting 
rid of the kvm subdirectory would be nice. What bits there are actually 
still in use today?

 From the top of my head, I only remember running kvm_stat and 
scripts/vmxcap from time to time. Obviously, there is nothing actively 
built anymore during normal qemu production. So what is the role of, e.g.,

  - kvm/bios
  - kvm/extboot
  - kvm/vgabios
  - kvm/scripts

today? Anything there we want to push upstream? And then drop the rest?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

Re: qemu-kvm: Remaining relevant bits in kvm/

[Marcelo Tosatti]

On Wed, Sep 28, 2011 at 05:05:57PM +0200, Jan Kiszka wrote:
> Hi all,
> 
> in order to reduce the diff between qemu-kvm.git and upstream,
> getting rid of the kvm subdirectory would be nice. What bits there
> are actually still in use today?
> 
> From the top of my head, I only remember running kvm_stat and
> scripts/vmxcap from time to time. Obviously, there is nothing
> actively built anymore during normal qemu production. So what is the
> role of, e.g.,
> 
>  - kvm/bios

Does not exist.

>  - kvm/extboot
>  - kvm/vgabios

Not needed, pc-bios/ version used instead.

>  - kvm/scripts
> 
> today? Anything there we want to push upstream? And then drop the rest?

Keep kvm_stat and scripts/ (other than vmxcap the *-release are still 
used), as far as i'm concerned.

Re: qemu-kvm: Remaining relevant bits in kvm/

[Jan Kiszka]

On 2011-09-29 19:10, Marcelo Tosatti wrote:
> On Wed, Sep 28, 2011 at 05:05:57PM +0200, Jan Kiszka wrote:
>> Hi all,
>>
>> in order to reduce the diff between qemu-kvm.git and upstream,
>> getting rid of the kvm subdirectory would be nice. What bits there
>> are actually still in use today?
>>
>> From the top of my head, I only remember running kvm_stat and
>> scripts/vmxcap from time to time. Obviously, there is nothing
>> actively built anymore during normal qemu production. So what is the
>> role of, e.g.,
>>
>>  - kvm/bios
> 
> Does not exist.

Indeed. Dunno why I saw this.

> 
>>  - kvm/extboot
>>  - kvm/vgabios
> 
> Not needed, pc-bios/ version used instead.
> 
>>  - kvm/scripts
>>
>> today? Anything there we want to push upstream? And then drop the rest?
> 
> Keep kvm_stat and scripts/ (other than vmxcap the *-release are still 
> used), as far as i'm concerned.

I don't want to keep things there. I want to push useful stuff upstream
and remove the rest. Alternatively, qemu-kvm specific release helpers
could be kept private in the top-level scripts/ of qemu-kvm.

My suggestion:
 - kvm/kvm_stat		-> qemu.git/scripts/kvm/kvm_stat
 - kvm/scripts/vmxcap	-> qemu.git/scripts/kvm/vmxcap
 - kvm/scripts/*-release-> qemu-kvm.git/scripts
 - rm -r kvm

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

Re: qemu-kvm: Remaining relevant bits in kvm/

[Avi Kivity]

On 09/29/2011 08:10 PM, Marcelo Tosatti wrote:
> On Wed, Sep 28, 2011 at 05:05:57PM +0200, Jan Kiszka wrote:
> >  Hi all,
> >
> >  in order to reduce the diff between qemu-kvm.git and upstream,
> >  getting rid of the kvm subdirectory would be nice. What bits there
> >  are actually still in use today?
> >
> >   From the top of my head, I only remember running kvm_stat and
> >  scripts/vmxcap from time to time. Obviously, there is nothing
> >  actively built anymore during normal qemu production. So what is the
> >  role of, e.g.,
> >
> >   - kvm/bios
>
> Does not exist.
>
> >   - kvm/extboot
> >   - kvm/vgabios
>
> Not needed, pc-bios/ version used instead.
>

Do we have everything in kvm/vgabios merged?  Lots of vga modelines IIRC.


-- 
error compiling committee.c: too many arguments to function

Re: qemu-kvm: Remaining relevant bits in kvm/

[Marcelo Tosatti]

On Sun, Oct 02, 2011 at 02:33:44PM +0200, Avi Kivity wrote:
> On 09/29/2011 08:10 PM, Marcelo Tosatti wrote:
> >On Wed, Sep 28, 2011 at 05:05:57PM +0200, Jan Kiszka wrote:
> >>  Hi all,
> >>
> >>  in order to reduce the diff between qemu-kvm.git and upstream,
> >>  getting rid of the kvm subdirectory would be nice. What bits there
> >>  are actually still in use today?
> >>
> >>   From the top of my head, I only remember running kvm_stat and
> >>  scripts/vmxcap from time to time. Obviously, there is nothing
> >>  actively built anymore during normal qemu production. So what is the
> >>  role of, e.g.,
> >>
> >>   - kvm/bios
> >
> >Does not exist.
> >
> >>   - kvm/extboot
> >>   - kvm/vgabios
> >
> >Not needed, pc-bios/ version used instead.
> >
> 
> Do we have everything in kvm/vgabios merged?  Lots of vga modelines IIRC.

There is one modeline pending:

http://lists.gnu.org/archive/html/qemu-devel/2010-12/msg00000.html

Anthony, can you please add that patch to qemu's vgabios so we can drop
kvm's entirely?