From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH] KVM: PPC: E500: Support hugetlbfs
Date: Wed, 5 Oct 2011 14:53:53 -0500
Message-ID: <4E8CB5D1.1050701@freescale.com>
References: <1317825450-605-1-git-send-email-agraf@suse.de> <4E8C8073.8080306@freescale.com> <C80D9E39-F4CC-4FE1-B943-A80E0600570A@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: <kvm@vger.kernel.org>, <kvm-ppc@vger.kernel.org>,
	<B13201@freescale.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from db3ehsobe002.messaging.microsoft.com ([213.199.154.140]:26234
	"EHLO DB3EHSOBE002.bigfish.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S933233Ab1JETyR (ORCPT
	<rfc822;kvm@vger.kernel.org>); Wed, 5 Oct 2011 15:54:17 -0400
In-Reply-To: <C80D9E39-F4CC-4FE1-B943-A80E0600570A@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 10/05/2011 01:55 PM, Alexander Graf wrote:
> 
> On 05.10.2011, at 18:06, Scott Wood wrote:
> 
>> Any reason for __ilog2() rather than ilog2()?  Shouldn't make a
>> difference, just curious about avoiding the public interface.
> 
> I grep'ed through the kernel tree and only found __ilog2 defined as well as mostly users for __ilog2, so I figured there's got to be a reason ;)

ilog2() is defined in include/linux/ilog2.h.  It produces constant
output if the input is constant, and appears to be the "front door" to
__ilog2_u32/__ilog2_u64.  Plain __ilog2 is older and powerpc-specific,
which is probably why there are more users of that in arch/powerpc.

-Scott