Re: [kvm-autotest] cgroup-kvm: Four new BlkioThrottle tests

["Lukáš Doktor" <ldoktor@redhat.com>]

Dne 7.10.2011 20:24, Lukas Doktor napsal(a):
> This is a patchset with four new tests to KVM specific cgroup testing. Also I made some modifications into (general) cgroup_common library which makes cgroup testing better readable and more safe to execute. Please find the details in each patch.
>
> Also please beware of qemu-kvm bugs which occurred for me (qemu-kvm 0.15.0 F17) which led to qemu SEGFAULTS or even to dysfunction (qemu-kvm 0.14 F15). I'll fill in Bugzilla on Monday.
>
> This was also sent as a github pull request, so if you feel like commenting on the pull request, be my guest:
> https://github.com/autotest/autotest/pull/33
>
> Best regards,
> Lukáš
Already one minor change, please follow the patches on github...

diff --git a/client/tests/kvm/tests/cgroup.py 
b/client/tests/kvm/tests/cgroup.py
index 7f00a6b..7407e29 100644
--- a/client/tests/kvm/tests/cgroup.py
+++ b/client/tests/kvm/tests/cgroup.py
@@ -409,7 +409,13 @@ def run_cgroup(test, params, env):
                  raise error.TestError("Corrupt class, aren't you 
trying to run
                                        "parent _TestBlkioThrottle() 
function?")

-            (self.files, self.devices) = add_scsi_drive(self.vm)
+            if get_device_driver() == "ide":
+                logging.warn("The main disk for this VM is ide wich 
doesn't "
+                             "support hot-plug. Using virtio_blk instead")
+                (self.files, self.devices) = add_scsi_drive(self.vm,
+                                                            
driver="virtio")
+            else:
+                (self.files, self.devices) = add_scsi_drive(self.vm)
              try:
                  dev = utils.system_output("ls -l %s" % 
self.files).split()[4:6]
                  dev[0] = dev[0][:-1]    # Remove tailing ','