From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v4 00/11] KVM: x86: optimize for writing guest page
Date: Sun, 09 Oct 2011 15:37:46 +0200 [thread overview]
Message-ID: <4E91A3AA.1000309@redhat.com> (raw)
In-Reply-To: <4E91926D.8060206@redhat.com>
On 10/09/2011 02:24 PM, Avi Kivity wrote:
> On 10/08/2011 06:06 AM, Xiao Guangrong wrote:
>> On 10/07/2011 01:53 AM, Marcelo Tosatti wrote:
>> > On Thu, Sep 22, 2011 at 04:52:40PM +0800, Xiao Guangrong wrote:
>> >> This patchset is against https://github.com/avikivity/kvm.git
>> next branch.
>> >>
>> >> In this version, some changes come from Avi's comments:
>> >> - fix instruction retried for nested guest
>> >> - skip write-flooding for the sp whose level is 1
>> >> - rename some functions
>> >
>> > Please rebase.
>> >
>> >
>>
>> Marcelo,
>>
>> These patches can be applied without any conflict and it also works
>> well,
>> the current code was pulled from https://github.com/avikivity/kvm.git
>> next branch.
>>
>> What problem did you meet when you applied these? :(
>
> I guess it was a user error - it applies cleanly here too (and pushed
> to next, thanks).
>
However, it seems to reduce performance.
Autotest results before:
Test Status Seconds Info
---- ------ ------- ----
(Result file: ../../results/default/status)
unittest GOOD 147
completed successfully
Fedora.9.32.install.smp2 GOOD 865
completed successfully
Fedora.9.32.boot.smp2 GOOD 46
completed successfully
Fedora.9.32.reboot.smp2 GOOD 49
completed successfully
Fedora.9.32.shutdown.smp2 GOOD 15
completed successfully
Fedora.9.64.install.smp2 GOOD 943
completed successfully
Fedora.9.64.boot.smp2 GOOD 47
completed successfully
Fedora.9.64.reboot.smp2 GOOD 48
completed successfully
Fedora.9.64.shutdown.smp2 GOOD 14
completed successfully
WinXP.32.install.smp2 GOOD 772
completed successfully
WinXP.32.setup.smp2 GOOD 53
completed successfully
WinXP.32.boot.smp2 GOOD 57
completed successfully
WinXP.32.reboot.smp2 GOOD 34
completed successfully
WinXP.32.shutdown.smp2 GOOD 5
completed successfully
WinXP.64.install.smp2 GOOD 636
completed successfully
After:
unittest GOOD 150
completed successfully
Fedora.9.32.install.smp2 GOOD 879
completed successfully
Fedora.9.32.boot.smp2 GOOD 50
completed successfully
Fedora.9.32.reboot.smp2 GOOD 48
completed successfully
Fedora.9.32.shutdown.smp2 GOOD 15
completed successfully
Fedora.9.64.install.smp2 GOOD 997
completed successfully
Fedora.9.64.boot.smp2 GOOD 47
completed successfully
Fedora.9.64.reboot.smp2 GOOD 48
completed successfully
Fedora.9.64.shutdown.smp2 GOOD 14
completed successfully
WinXP.32.install.smp2 GOOD 764
completed successfully
WinXP.32.setup.smp2 GOOD 51
completed successfully
WinXP.32.boot.smp2 GOOD 40
completed successfully
WinXP.32.reboot.smp2 GOOD 34
completed successfully
WinXP.32.shutdown.smp2 GOOD 5
completed successfully
WinXP.64.install.smp2 GOOD 666
completed successfully
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-10-09 13:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 8:52 [PATCH v4 00/11] KVM: x86: optimize for writing guest page Xiao Guangrong
2011-09-22 8:53 ` [PATCH v4 01/11] KVM: MMU: avoid pte_list_desc running out in kvm_mmu_pte_write Xiao Guangrong
2011-09-22 8:53 ` [PATCH v4 02/11] KVM: x86: tag the instructions which are used to write page table Xiao Guangrong
2011-09-22 8:55 ` [PATCH v4 04/11] KVM: x86: cleanup port-in/port-out emulated Xiao Guangrong
2011-09-22 8:55 ` [PATCH v4 05/11] KVM: MMU: do not mark accessed bit on pte write path Xiao Guangrong
2011-09-22 8:56 ` [PATCH v4 06/11] KVM: MMU: cleanup FNAME(invlpg) Xiao Guangrong
2011-09-22 8:56 ` [PATCH v4 07/11] KVM: MMU: fast prefetch spte on invlpg path Xiao Guangrong
2011-09-22 8:56 ` [PATCH v4 08/11] KVM: MMU: remove unnecessary kvm_mmu_free_some_pages Xiao Guangrong
2011-09-22 8:57 ` [PATCH v4 09/11] KVM: MMU: split kvm_mmu_pte_write function Xiao Guangrong
2011-09-22 8:57 ` [PATCH v4 10/11] KVM: MMU: fix detecting misaligned accessed Xiao Guangrong
2011-09-22 8:58 ` [PATCH v4 11/11] KVM: MMU: improve write flooding detected Xiao Guangrong
2011-09-22 9:02 ` [PATCH v4 03/11] KVM: x86: retry non-page-table writing instructions Xiao Guangrong
2011-09-23 11:51 ` [PATCH v4 00/11] KVM: x86: optimize for writing guest page Marcelo Tosatti
2011-09-30 3:49 ` Xiao Guangrong
2011-10-05 13:25 ` Avi Kivity
2011-10-06 17:50 ` Marcelo Tosatti
2011-10-06 17:53 ` Marcelo Tosatti
2011-10-08 4:06 ` Xiao Guangrong
2011-10-09 12:24 ` Avi Kivity
2011-10-09 13:37 ` Avi Kivity [this message]
2011-10-11 8:36 ` Xiao Guangrong
2011-11-04 9:16 ` Xiao Guangrong
2011-11-06 15:35 ` Avi Kivity
2011-11-10 13:28 ` Xiao Guangrong
2011-11-10 14:05 ` Avi Kivity
2011-11-11 3:42 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E91A3AA.1000309@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).