From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [RFC PATCH 1/7] [hyper-v] Add hyper-v parameters block.
Date: Mon, 10 Oct 2011 08:54:04 +0200
Message-ID: <4E92968C.2000306@web.de>
References: <1318186375-27672-1-git-send-email-vrozenfe@redhat.com> <1318186375-27672-2-git-send-email-vrozenfe@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigC55714A3FA7927541C31D8D0"
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
To: Vadim Rozenfeld <vrozenfe@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate03.web.de ([217.72.192.234]:45721 "EHLO
	fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751381Ab1JJGyG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 10 Oct 2011 02:54:06 -0400
In-Reply-To: <1318186375-27672-2-git-send-email-vrozenfe@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigC55714A3FA7927541C31D8D0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2011-10-09 20:52, Vadim Rozenfeld wrote:
> ---
>  qemu-options.hx |   23 +++++++++++++++++++++++
>  vl.c            |    2 ++
>  2 files changed, 25 insertions(+), 0 deletions(-)
>=20
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 3a13533..9f60059 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2483,6 +2483,29 @@ DEF("kvm-shadow-memory", HAS_ARG, QEMU_OPTION_kv=
m_shadow_memory,
>      "                allocate MEGABYTES for kvm mmu shadowing\n",
>      QEMU_ARCH_I386)
> =20
> +DEF("hyperv", HAS_ARG, QEMU_OPTION_hyperv,
> +    "-hyperv [vapic=3Don|off][,spinlock=3Dretries][,wd=3Don|off]\n"
> +    "                enable Hyper-V Enlightenment\n",
> +        QEMU_ARCH_ALL)

These are CPU feature, so -cpu +/-hv_vapic,+/-hv_spinlock etc. looks
more appropriate than a new command line parameter.

BTW, documentation and maybe also option processing should make clear
that this is limited to KVM mode for now.

Jan


--------------enigC55714A3FA7927541C31D8D0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6Slo0ACgkQitSsb3rl5xRjDQCeOEqbVUfWDBcemHpg+0x7qFiK
ZgkAn0b5kTUDB6ocIGwzkxQFkxOzH1Gb
=rhJg
-----END PGP SIGNATURE-----

--------------enigC55714A3FA7927541C31D8D0--