Re: [RFC PATCH 3/7] [hyper-v] make Hyper-V option configurable.

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 2714 bytes --]

On 2011-10-09 20:52, Vadim Rozenfeld wrote:
> ---
>  Makefile.target |    1 +
>  configure       |   11 +++++++++++
>  2 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile.target b/Makefile.target
> index f84d8cb..3581480 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -199,6 +199,7 @@ obj-$(CONFIG_VHOST_NET) += vhost.o
>  obj-$(CONFIG_REALLY_VIRTFS) += 9pfs/virtio-9p-device.o
>  obj-$(CONFIG_KVM) += kvm.o kvm-all.o
>  obj-$(CONFIG_NO_KVM) += kvm-stub.o
> +obj-$(CONFIG_HYPERV) += hyperv.o
>  obj-y += memory.o
>  LIBS+=-lz
>  
> diff --git a/configure b/configure
> index 94c7d31..f5ecfd7 100755
> --- a/configure
> +++ b/configure
> @@ -150,6 +150,7 @@ debug="no"
>  strip_opt="yes"
>  bigendian="no"
>  mingw32="no"
> +hyperv="no"
>  EXESUF=""
>  prefix="/usr/local"
>  mandir="\${prefix}/share/man"
> @@ -762,6 +763,10 @@ for opt do
>    ;;
>    --enable-vhost-net) vhost_net="yes"
>    ;;
> +  --disable-hyperv) hyperv="no"
> +  ;;
> +  --enable-hyperv) hyperv="yes"
> +  ;;
>    --disable-opengl) opengl="no"
>    ;;
>    --enable-opengl) opengl="yes"
> @@ -1062,6 +1067,8 @@ echo "  --enable-docs            enable documentation build"
>  echo "  --disable-docs           disable documentation build"
>  echo "  --disable-vhost-net      disable vhost-net acceleration support"
>  echo "  --enable-vhost-net       enable vhost-net acceleration support"
> +echo "  --enable-hyperv          enable Hyper-V support"
> +echo "  --disable-hyperv         disable Hyper-V support"
>  echo "  --enable-trace-backend=B Set trace backend"
>  echo "                           Available backends:" $("$source_path"/scripts/tracetool --list-backends)
>  echo "  --with-trace-file=NAME   Full PATH,NAME of file to store traces"
> @@ -2737,6 +2744,7 @@ echo "madvise           $madvise"
>  echo "posix_madvise     $posix_madvise"
>  echo "uuid support      $uuid"
>  echo "vhost-net support $vhost_net"
> +echo "Hyper-V support   $hyperv"
>  echo "Trace backend     $trace_backend"
>  echo "Trace output file $trace_file-<pid>"
>  echo "spice support     $spice"
> @@ -3424,6 +3432,9 @@ case "$target_arch2" in
>        if test $kvm_cap_device_assignment = "yes" ; then
>          echo "CONFIG_KVM_DEVICE_ASSIGNMENT=y" >> $config_target_mak
>        fi
> +      if test "$hyperv" = "yes" ; then
> +        echo "CONFIG_HYPERV=y" >> $config_target_mak
> +      fi
>      fi
>  esac
>  if test "$target_bigendian" = "yes" ; then

Why do I want to --disable-hyperv? It rather looks like we could
perfectly live with this feature built by default. Would also allow to
drop the nasty #ifdefs from the code.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]