From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [RFC PATCH 3/7] [hyper-v] make Hyper-V option configurable.
Date: Mon, 10 Oct 2011 08:54:35 +0200
Message-ID: <4E9296AB.8020808@web.de>
References: <1318186375-27672-1-git-send-email-vrozenfe@redhat.com> <1318186375-27672-4-git-send-email-vrozenfe@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig0BB7A202AC6D4BEB7A6E110D"
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
To: Vadim Rozenfeld <vrozenfe@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate01.web.de ([217.72.192.221]:56113 "EHLO
	fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751533Ab1JJGyh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 10 Oct 2011 02:54:37 -0400
In-Reply-To: <1318186375-27672-4-git-send-email-vrozenfe@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig0BB7A202AC6D4BEB7A6E110D
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2011-10-09 20:52, Vadim Rozenfeld wrote:
> ---
>  Makefile.target |    1 +
>  configure       |   11 +++++++++++
>  2 files changed, 12 insertions(+), 0 deletions(-)
>=20
> diff --git a/Makefile.target b/Makefile.target
> index f84d8cb..3581480 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -199,6 +199,7 @@ obj-$(CONFIG_VHOST_NET) +=3D vhost.o
>  obj-$(CONFIG_REALLY_VIRTFS) +=3D 9pfs/virtio-9p-device.o
>  obj-$(CONFIG_KVM) +=3D kvm.o kvm-all.o
>  obj-$(CONFIG_NO_KVM) +=3D kvm-stub.o
> +obj-$(CONFIG_HYPERV) +=3D hyperv.o
>  obj-y +=3D memory.o
>  LIBS+=3D-lz
> =20
> diff --git a/configure b/configure
> index 94c7d31..f5ecfd7 100755
> --- a/configure
> +++ b/configure
> @@ -150,6 +150,7 @@ debug=3D"no"
>  strip_opt=3D"yes"
>  bigendian=3D"no"
>  mingw32=3D"no"
> +hyperv=3D"no"
>  EXESUF=3D""
>  prefix=3D"/usr/local"
>  mandir=3D"\${prefix}/share/man"
> @@ -762,6 +763,10 @@ for opt do
>    ;;
>    --enable-vhost-net) vhost_net=3D"yes"
>    ;;
> +  --disable-hyperv) hyperv=3D"no"
> +  ;;
> +  --enable-hyperv) hyperv=3D"yes"
> +  ;;
>    --disable-opengl) opengl=3D"no"
>    ;;
>    --enable-opengl) opengl=3D"yes"
> @@ -1062,6 +1067,8 @@ echo "  --enable-docs            enable documenta=
tion build"
>  echo "  --disable-docs           disable documentation build"
>  echo "  --disable-vhost-net      disable vhost-net acceleration suppor=
t"
>  echo "  --enable-vhost-net       enable vhost-net acceleration support=
"
> +echo "  --enable-hyperv          enable Hyper-V support"
> +echo "  --disable-hyperv         disable Hyper-V support"
>  echo "  --enable-trace-backend=3DB Set trace backend"
>  echo "                           Available backends:" $("$source_path"=
/scripts/tracetool --list-backends)
>  echo "  --with-trace-file=3DNAME   Full PATH,NAME of file to store tra=
ces"
> @@ -2737,6 +2744,7 @@ echo "madvise           $madvise"
>  echo "posix_madvise     $posix_madvise"
>  echo "uuid support      $uuid"
>  echo "vhost-net support $vhost_net"
> +echo "Hyper-V support   $hyperv"
>  echo "Trace backend     $trace_backend"
>  echo "Trace output file $trace_file-<pid>"
>  echo "spice support     $spice"
> @@ -3424,6 +3432,9 @@ case "$target_arch2" in
>        if test $kvm_cap_device_assignment =3D "yes" ; then
>          echo "CONFIG_KVM_DEVICE_ASSIGNMENT=3Dy" >> $config_target_mak
>        fi
> +      if test "$hyperv" =3D "yes" ; then
> +        echo "CONFIG_HYPERV=3Dy" >> $config_target_mak
> +      fi
>      fi
>  esac
>  if test "$target_bigendian" =3D "yes" ; then

Why do I want to --disable-hyperv? It rather looks like we could
perfectly live with this feature built by default. Would also allow to
drop the nasty #ifdefs from the code.

Jan


--------------enig0BB7A202AC6D4BEB7A6E110D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6SlqsACgkQitSsb3rl5xQWlQCfSEywdqZaQtL9rPM754wDQSlt
/fMAnj2K3DSHbyNaPLBHmllEzMf1Dv9g
=so7X
-----END PGP SIGNATURE-----

--------------enig0BB7A202AC6D4BEB7A6E110D--