From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC PATCH 1/7] [hyper-v] Add hyper-v parameters block. Date: Mon, 10 Oct 2011 12:25:30 +0200 Message-ID: <4E92C81A.4050107@siemens.com> References: <1318186375-27672-1-git-send-email-vrozenfe@redhat.com> <1318186375-27672-2-git-send-email-vrozenfe@redhat.com> <4E92968C.2000306@web.de> <1318239652.2706.27.camel@vadimr.dell> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Avi Kivity To: Vadim Rozenfeld Return-path: Received: from goliath.siemens.de ([192.35.17.28]:25617 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753097Ab1JJKZh (ORCPT ); Mon, 10 Oct 2011 06:25:37 -0400 In-Reply-To: <1318239652.2706.27.camel@vadimr.dell> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-10-10 11:40, Vadim Rozenfeld wrote: > On Mon, 2011-10-10 at 08:54 +0200, Jan Kiszka wrote: >> On 2011-10-09 20:52, Vadim Rozenfeld wrote: >>> --- >>> qemu-options.hx | 23 +++++++++++++++++++++++ >>> vl.c | 2 ++ >>> 2 files changed, 25 insertions(+), 0 deletions(-) >>> >>> diff --git a/qemu-options.hx b/qemu-options.hx >>> index 3a13533..9f60059 100644 >>> --- a/qemu-options.hx >>> +++ b/qemu-options.hx >>> @@ -2483,6 +2483,29 @@ DEF("kvm-shadow-memory", HAS_ARG, QEMU_OPTION_kvm_shadow_memory, >>> " allocate MEGABYTES for kvm mmu shadowing\n", >>> QEMU_ARCH_I386) >>> >>> +DEF("hyperv", HAS_ARG, QEMU_OPTION_hyperv, >>> + "-hyperv [vapic=on|off][,spinlock=retries][,wd=on|off]\n" >>> + " enable Hyper-V Enlightenment\n", >>> + QEMU_ARCH_ALL) >> >> These are CPU feature, so -cpu +/-hv_vapic,+/-hv_spinlock etc. looks >> more appropriate than a new command line parameter. >> > I would like to keep hyper-v settings apart from cpu features for a very > simple reason: if hyper-v VMBus support will be added one day, it won't > be a CPU only feature anymore. Then that feature would be controlled by adding the corresponding device. There is no need for -hyperv. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux