From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"yongjie.ren@intel.com" <yongjie.ren@intel.com>
Subject: Re: [PATCH 2/2] pci-assign: Fix MSI-X registration
Date: Mon, 10 Oct 2011 15:55:51 +0200 [thread overview]
Message-ID: <4E92F967.3070601@redhat.com> (raw)
In-Reply-To: <4E7AFA02.5010409@siemens.com>
On 09/22/2011 12:04 PM, Jan Kiszka wrote:
> > goto out;
> >
> > + if (!kvm_check_extension(kvm_state, KVM_CAP_ASSIGN_DEV_IRQ)&&
> > + (dev->cap.available& ASSIGNED_DEVICE_CAP_MSIX ||
> > + dev->cap.available& ASSIGNED_DEVICE_CAP_MSI ||
> > + assigned_dev_pci_read_byte(pci_dev, PCI_INTERRUPT_PIN) != 0)) {
> > + goto out;
> > + }
> > +
>
> That's not equivalent as it needlessly prevents IRQ support in the
> absence of KVM_CAP_ASSIGN_DEV_IRQ.
>
> Let's just fix the core issue and replace the test for
> KVM_CAP_DEVICE_MSIX with a test call of KVM_ASSIGN_SET_MSIX_NR, passing
> in a NULL struct. If it returns -EFAULT, the IOCTL is known and MSIX is
> supported.
>
Or just add KVM_CAP_DEVICE_MSIX to the kernel and backport it where needed?
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-10-10 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 3:12 [PATCH 0/2] pci-assign: Fix MSI-X support Alex Williamson
2011-09-22 3:12 ` [PATCH 1/2] pci-assign: Re-order initfn for memory API Alex Williamson
2011-09-22 9:03 ` Jan Kiszka
2011-09-22 3:12 ` [PATCH 2/2] pci-assign: Fix MSI-X registration Alex Williamson
2011-09-22 9:04 ` Jan Kiszka
2011-10-10 13:55 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E92F967.3070601@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=yongjie.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).