From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0/1] [PULL] qemu-kvm.git uq/master queue Date: Mon, 10 Oct 2011 10:36:51 -0500 Message-ID: <4E931113.1000905@us.ibm.com> References: <4E930409.6060000@us.ibm.com> <4E9305BD.70809@redhat.com> <4E930774.90806@us.ibm.com> <4E93089B.1080008@redhat.com> <4E930B55.70206@codemonkey.ws> <4E930E33.7090606@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: In-Reply-To: <4E930E33.7090606@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 10/10/2011 10:24 AM, Avi Kivity wrote: > On 10/10/2011 05:12 PM, Anthony Liguori wrote: >> On 10/10/2011 10:00 AM, Avi Kivity wrote: >>> On 10/10/2011 04:55 PM, Anthony Liguori wrote: >>>> >>>> Hrm, sorry about that. In the future, it would be helpful to explicitly >>>> withdrawal a PULL request. >>>> >>>> Do you want me to revert? >>> >>> We'll send the revert together with the new patch. >>> >>>> FWIW, I think bumping the version is the right thing to do. >>> >>> Why? >> >> Because we still haven't fixed subsections. Juan's patches help but they can >> still result in sending bad data to and older QEMU that won't handle it properly. >> >> We need to figure out a proper fix for subsections, either Paolo's protocol >> change or moving subsections out to a detected section. > > Ok. So bumping the version is only right if we don't fix subsections. If we bump *any* version from 0.15 -> 1.0, then there's no point at all in having a subsection. If we break compatibility by using Paolo's new protocol, or doing subsections as sections, then there's no point in making it a subsection either. Regards, Anthony Liguori >