From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH 2/7] [hyper-v] add hyper-v placeholders. Date: Tue, 11 Oct 2011 09:40:46 +0200 Message-ID: <4E93F2FE.2010307@redhat.com> References: <1318186375-27672-1-git-send-email-vrozenfe@redhat.com> <1318186375-27672-3-git-send-email-vrozenfe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Avi Kivity To: Vadim Rozenfeld Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:41261 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872Ab1JKHkt (ORCPT ); Tue, 11 Oct 2011 03:40:49 -0400 Received: by wwf22 with SMTP id 22so10100058wwf.1 for ; Tue, 11 Oct 2011 00:40:48 -0700 (PDT) In-Reply-To: <1318186375-27672-3-git-send-email-vrozenfe@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/09/2011 08:52 PM, Vadim Rozenfeld wrote: > --- > hyperv.c | 3 +++ > hyperv.h | 10 ++++++++++ Please move these to target-i386, and add a license header. Also, I don't think it is necessary to add a new configure option; just leave it enabled by default and add CONFIG_HYPERV=y to default-configs/i386-softmmu.mak and default-configs/x86_64-softmmu.mak. Paolo