From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 2/4] block: add the command line support
Date: Mon, 17 Oct 2011 12:19:46 +0200
Message-ID: <4E9C0142.3030107@redhat.com>
References: <1315476668-19812-1-git-send-email-wuzhy@linux.vnet.ibm.com> <1315476668-19812-3-git-send-email-wuzhy@linux.vnet.ibm.com> <4E7CABC0.4050501@redhat.com> <CAEH94Lg8MPXs=QG=YmFDTQGgqeP7p+mFELtHZeChU=ccGFoWDw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
	kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
	pair@us.ibm.com, ryanh@us.ibm.com,
	Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:4590 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751225Ab1JQKQr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 17 Oct 2011 06:16:47 -0400
In-Reply-To: <CAEH94Lg8MPXs=QG=YmFDTQGgqeP7p+mFELtHZeChU=ccGFoWDw@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 26.09.2011 08:15, schrieb Zhi Yong Wu:
> On Fri, Sep 23, 2011 at 11:54 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>>> +}
>>> +
>>> +static void bdrv_block_timer(void *opaque)
>>> +{
>>> +    BlockDriverState *bs = opaque;
>>> +    BlockQueue *queue    = bs->block_queue;
>>> +
>>> +    qemu_block_queue_flush(queue);
>>
>> Hm, didn't really notice it while reading patch 1, but
>> qemu_block_queue_flush() is misleading. It's really something like
> Why do you say this is misleading?
>> qemu_block_queue_submit().
> Right. It will resubmit all enqueued I/O requests.

For me, flush sounds as if it waits for completion of all requests.

Kevin