From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC][PATCH 42/45] msix: Introduce msix_init_simple Date: Mon, 17 Oct 2011 13:27:31 +0200 Message-ID: <4E9C1123.4070204@siemens.com> References: <20111017112217.GC4537@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , Alex Williamson , "qemu-devel@nongnu.org" To: "Michael S. Tsirkin" Return-path: Received: from thoth.sbs.de ([192.35.17.2]:30181 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095Ab1JQL1g (ORCPT ); Mon, 17 Oct 2011 07:27:36 -0400 In-Reply-To: <20111017112217.GC4537@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-10-17 13:22, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:28:16AM +0200, Jan Kiszka wrote: >> Devices models are usually not interested in specifying MSI-X >> configuration details beyond the number of vectors to provide and the >> BAR number to use. Layout of an exclusively used BAR and its >> registration can also be handled centrally. >> >> This is the purpose of msix_init_simple. It provides handy services to >> the existing users. Future users like device assignment may require more >> detailed setup specification. For them we will (re-)introduce msix_init >> with the full list of configuration option (in contrast to the current >> code). >> >> Signed-off-by: Jan Kiszka > > Well, this seems a bit of a code churn then, doesn't it? > We are also discussing using memory BAR for virtio-pci for other > stuff besides MSI-X, so the last user of the _simple variant > will be ivshmem then? We will surely see more MSI-X users over the time. Not sure if they all mix their MSIX-X BARs with other stuff. But e.g. the e1000 variant I have here does not. So there should be users in the future. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux