From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH 17/45] qemu-kvm: Track MSIRoutingCache in KVM routing table Date: Mon, 17 Oct 2011 14:15:52 +0200 Message-ID: <4E9C1C78.5030003@redhat.com> References: <76a09d29c3ff24930642b36302ce41dd96824ca1.1318843693.git.jan.kiszka@siemens.com> <4E9C0DF5.8050209@redhat.com> <4E9C10A8.4060706@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alex Williamson , Marcelo Tosatti , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Michael S. Tsirkin" To: Jan Kiszka Return-path: In-Reply-To: <4E9C10A8.4060706@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 10/17/2011 01:25 PM, Jan Kiszka wrote: > On 2011-10-17 13:13, Avi Kivity wrote: > > On 10/17/2011 11:27 AM, Jan Kiszka wrote: > >> Keep a link from the internal KVM routing table to potential MSI routing > >> cache entries. The link is used so far whenever the entry is dropped to > >> invalidate the cache content. It will allow us to build MSI routing > >> entries on demand and flush existing ones on table overflow. > >> > > > > Does this not require a destructor for MSIRoutingCache? > > Yes, kvm_msi_cache_invalidate. Cache providers are responsible for > invalidating used caches before freeing them. That also drops the > reference established here. Ah, apic.c's cache is static. It looked to me as if you're immediately leaking references to it, but you aren't. -- error compiling committee.c: too many arguments to function