From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors Date: Mon, 17 Oct 2011 21:28:12 +0200 Message-ID: <4E9C81CC.5040900@web.de> References: <20111017154852.GC7876@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8C2725B3B5FF8A95273EB68C" Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , Alex Williamson , "qemu-devel@nongnu.org" To: "Michael S. Tsirkin" Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:40308 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757232Ab1JRJx4 (ORCPT ); Tue, 18 Oct 2011 05:53:56 -0400 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate02.web.de (Postfix) with ESMTP id 50F961B45DA19 for ; Mon, 17 Oct 2011 21:33:23 +0200 (CEST) In-Reply-To: <20111017154852.GC7876@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8C2725B3B5FF8A95273EB68C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-10-17 17:48, Michael S. Tsirkin wrote: > On Mon, Oct 17, 2011 at 11:28:02AM +0200, Jan Kiszka wrote: >> This optimization was only required to keep KVM route usage low. Now >> that we solve that problem via lazy updates, we can drop the field. We= >> still need interfaces to clear pending vectors, though (and we have to= >> make use of them more broadly - but that's unrelated to this patch). >> >> Signed-off-by: Jan Kiszka >=20 > Lazy updates should be an implementation detail. > IMO resource tracking of vectors makes sense > as an API. Making devices deal with pending > vectors as a concept, IMO, does not. There is really no use for tracking the vector lifecycle once we have lazy updates (except for static routes). It's a way too invasive concept, and it's not needed for anything but KVM. If you want an example, check http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/70915 and compare it to the changes done to hpet in this series. Jan --------------enig8C2725B3B5FF8A95273EB68C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6cgcwACgkQitSsb3rl5xTMJACg0ZF2W7PwyiDJ6VChI3z/nbss EYAAnR31IrKHFoVO/WMEYJMCpAXgUbU3 =TkZw -----END PGP SIGNATURE----- --------------enig8C2725B3B5FF8A95273EB68C--