From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/5] qemu-kvm: msix: Don't fire notifier spuriously on set/unset Date: Tue, 18 Oct 2011 13:34:39 +0200 Message-ID: <4E9D644F.2000705@siemens.com> References: <0cc8d4ef4adb06b4ee6370488609352dae6fa3df.1318924251.git.jan.kiszka@siemens.com> <20111018110607.GB28776@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" To: "Michael S. Tsirkin" Return-path: Received: from goliath.siemens.de ([192.35.17.28]:20276 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754721Ab1JRLeo (ORCPT ); Tue, 18 Oct 2011 07:34:44 -0400 In-Reply-To: <20111018110607.GB28776@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-10-18 13:06, Michael S. Tsirkin wrote: > On Tue, Oct 18, 2011 at 09:50:50AM +0200, Jan Kiszka wrote: >> If MSI-X is disabled or the global mask is set, don't fire the notifier >> during registration or removal, reporting a wrong state. >> >> Signed-off-by: Jan Kiszka > > Hmm. Could you please describe how does one trigger the incorrect behaviour? > Looking at the upstream code, I notice that msix_notify_if_unmasked > already calls msix_is_masked which checks the function mask. And it > also checks msix_entry_used which, ATM, is only set when msix is > enabled. Right, that's not yet an issue. Will be required when we get rid of used vector tracking. Will adjust the commit log accordingly and move it back into that context. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux