From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiao.guangrong@qq.com>
Subject: Re: [PATCH] KVM: MMU: fix the condition of syncing a new shadow page
Date: Mon, 24 Oct 2011 15:46:31 +0800
Message-ID: <4EA517D7.6060407@qq.com>
References: <1319440880-2610-1-git-send-email-cronozhj@gmail.com> <1319440880-2610-2-git-send-email-cronozhj@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: avi@redhat.com, mtosatti@redhat.com, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org
To: Zhao Jin <cronozhj@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1319440880-2610-2-git-send-email-cronozhj@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 2011/10/24 15:21, Zhao Jin wrote:
> Should be "or" since a new shadow page is synced if either it is
> not leaf or there already exists another unsync shadow page with 
> the same gfn.
> 

It is obviously wrong, we need to sync pages only if it has unsync page
*and* the new shadow page breaks the unsync rule(only the level 1 sp can
became unsync).