Re: [PATCH RFC V2 4/5] kvm guest : Added configuration support to enable debug information for KVM Guests

[Jeremy Fitzhardinge <jeremy@goop.org>]

On 10/24/2011 03:15 AM, Avi Kivity wrote:
> On 10/23/2011 09:07 PM, Raghavendra K T wrote:
>> Added configuration support to enable debug information
>> for KVM Guests in debugfs
>>     
>> Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
>> Signed-off-by: Suzuki Poulose <suzuki@in.ibm.com>
>> Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
>> ---
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 1f03f82..ed34269 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -562,6 +562,15 @@ config KVM_GUEST
>>  	  This option enables various optimizations for running under the KVM
>>  	  hypervisor.
>>  
>> +config KVM_DEBUG_FS
>> +	bool "Enable debug information for KVM Guests in debugfs"
>> +	depends on KVM_GUEST
>> +	default n
>> +	---help---
>> +	  This option enables collection of various statistics for KVM guest.
>> +   	  Statistics are displayed in debugfs filesystem. Enabling this option
>> +	  may incur significant overhead.
>> +
>>  source "arch/x86/lguest/Kconfig"
>>  
>>
> This might be better implemented through tracepoints, which an be
> enabled dynamically.

Tracepoints use spinlocks, so that could get awkward.

    J