From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCHv4] virtio-blk: use ida to allocate disk index Date: Mon, 31 Oct 2011 08:05:55 +0100 Message-ID: <4EAE48D3.4090504@kernel.dk> References: <20111030192959.GA31143@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Rusty Russell , Tejun Heo , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20111030192959.GA31143@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 2011-10-30 20:29, Michael S. Tsirkin wrote: > Based on a patch by Mark Wu > > Current index allocation in virtio-blk is based on a monotonically > increasing variable "index". This means we'll run out of numbers > after a while. It also could cause confusion about the disk > name in the case of hot-plugging disks. > Change virtio-blk to use ida to allocate index, instead. > > Signed-off-by: Michael S. Tsirkin > --- > > Changes from Mark's versions: > use the new ida_simple_get > error handling cleanup > fix user after free > > Works fine for me. > > Jens, could you merge this for 3.2? > That is, unless Rusty complains shortly ... Yep, tentatively added. -- Jens Axboe