From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: Re: [SeaBIOS] [PATCH RFC] acpi: add ssdt for cpi hotplug Date: Thu, 03 Nov 2011 09:04:57 +0800 Message-ID: <4EB1E8B9.7050408@cn.fujitsu.com> References: <20111101191139.GA18317@redhat.com> <20111101225901.GB31374@morn.localdomain> <20111102085442.GF5613@redhat.com> <20111103003028.GA16459@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , seabios@seabios.org, kvm@vger.kernel.org To: "Kevin O'Connor" Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:56717 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754266Ab1KCBDV (ORCPT ); Wed, 2 Nov 2011 21:03:21 -0400 In-Reply-To: <20111103003028.GA16459@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: At 11/03/2011 08:30 AM, Kevin O'Connor Write: > On Wed, Nov 02, 2011 at 10:54:42AM +0200, Michael S. Tsirkin wrote: >> On Tue, Nov 01, 2011 at 06:59:01PM -0400, Kevin O'Connor wrote: >>> Can we leave these parts in the DSDT and only move the bulk generated >>> stuff to the SSDT? >>> >> They can, but I thought one of the reasons we do the split >> is to make it possible for users to supply their own DSDT? >> If so creating calls from SSDT into DSDT would make this very fragile. > > I think it's reasonable to require that a user supplied DSDT still > fill certain requirements. Keep in mind that the reason for the "user > supplied" DSDT was for new platform (q35) development - not > necessarily so each individual user could set their own. I do not think it's reasonable to require that a user supplied DSDT still fill certain requiements. I think we should not use default SSDT if we use user supplied DSDT. If we use user supplied DSDT, we should use user supplied SSDT too. Thanks Wen Congyang > > It's not great to have the DSDT and SSDT tied to each other. However, > once RMV is removed, it's only two methods (PCNT supplied by the SSDT > and PCEJ supplied by the DSDT). > > I do see the upside to moving it all to the SSDT - but that has the > disadvantage of taking away the ability of a user supplied DSDT to > tweak how the hotplug functions work. Also, we'd then want to redo > CPU hotplug to be the same way. > > -Kevin > > _______________________________________________ > SeaBIOS mailing list > SeaBIOS@seabios.org > http://www.seabios.org/mailman/listinfo/seabios >