From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [1.0 release work] Fix regressions found on recent KVM autotest
 qemu master 'sanity' jobs
Date: Fri, 04 Nov 2011 14:52:07 -0200
Message-ID: <4EB41837.9070706@redhat.com>
References: <4EB41575.8070508@redhat.com> <4EB417ED.9010903@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: QEMU devel <qemu-devel@nongnu.org>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	KVM mailing list <kvm@vger.kernel.org>,
	Cleber Rosa <crosa@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:11992 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755612Ab1KDQwH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 4 Nov 2011 12:52:07 -0400
In-Reply-To: <4EB417ED.9010903@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri 04 Nov 2011 02:50:53 PM BRST, Kevin Wolf wrote:
> Am 04.11.2011 17:40, schrieb Lucas Meneghel Rodrigues:
>> 2) The floppy regression problem which was reported some days ago on
>> this mailing list still happens, Kevin did post a patch that resolves it
>>
>> [...]
>>
>> But still wasn't integrated upstream. As I understand, there are doubts
>> whether this is a proper fix. Works with qemu-kvm.git. RHEL 5 and RHEL 6.
>
> The first patch was buggy (even though it seemed to do the trick in most
> cases), but I do have a new version queued for my next pull request.
>
> In case you like to test it before it gets merged, this is the new version:
>
> diff --git a/hw/dma.c b/hw/dma.c
> index 8a7302a..0a9322d 100644
> --- a/hw/dma.c
> +++ b/hw/dma.c
> @@ -358,6 +358,14 @@ static void DMA_run (void)
>       struct dma_cont *d;
>       int icont, ichan;
>       int rearm = 0;
> +    static int running = 0;
> +
> +    if (running) {
> +        rearm = 1;
> +        goto out;
> +    } else {
> +        running = 1;
> +    }
>
>       d = dma_controllers;
>
> @@ -374,6 +382,8 @@ static void DMA_run (void)
>           }
>       }
>
> +    running = 0;
> +out:
>       if (rearm)
>           qemu_bh_schedule_idle(dma_bh);
>   }
>
> Kevin

Ok, we'll put it on our off tree patch stash for the next upstream jobs 
[1], thanks. We still have the bios problem to finally get a working 
windows install, I hope people might look into this.

[1] Well, currently this is the only patch on our 'stash', we only 
resort to external patches on blockers like this one.