From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1.0] ac97: don't override the pci subsystem id Date: Mon, 07 Nov 2011 16:17:58 +0200 Message-ID: <4EB7E896.9010108@redhat.com> References: <1320663634-29453-1-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Takashi Iwai To: Gerd Hoffmann Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18202 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819Ab1KGOSI (ORCPT ); Mon, 7 Nov 2011 09:18:08 -0500 In-Reply-To: <1320663634-29453-1-git-send-email-kraxel@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: > This patch removes the code lines which set the subsystem id for the > emulated ac97 card to 8086:0000. Due to the device id being zero the > subsystem id isn't vaild anyway. With the patch applied the sound card > gets the default qemu subsystem id (1af4:1100) instead. > > Cc: Takashi Iwai > Signed-off-by: Gerd Hoffmann > --- > hw/ac97.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/hw/ac97.c b/hw/ac97.c > index 6800af4..b43e435 100644 > --- a/hw/ac97.c > +++ b/hw/ac97.c > @@ -1305,12 +1305,6 @@ static int ac97_initfn (PCIDevice *dev) > c[PCI_BASE_ADDRESS_0 + 6] = 0x00; > c[PCI_BASE_ADDRESS_0 + 7] = 0x00; > > - c[PCI_SUBSYSTEM_VENDOR_ID] = 0x86; /* svid subsystem vendor id rwo */ > - c[PCI_SUBSYSTEM_VENDOR_ID + 1] = 0x80; > - > - c[PCI_SUBSYSTEM_ID] = 0x00; /* sid subsystem id rwo */ > - c[PCI_SUBSYSTEM_ID + 1] = 0x00; > - This a guest ABI change. Do we want -M support for it? -- error compiling committee.c: too many arguments to function