From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem
 id
Date: Mon, 07 Nov 2011 08:39:07 -0600
Message-ID: <4EB7ED8B.4090505@codemonkey.ws>
References: <1320663634-29453-1-git-send-email-kraxel@redhat.com>	<4EB7E896.9010108@redhat.com> <4EB7EC4A.90607@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Takashi Iwai <tiwai@suse.de>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Gerd Hoffmann <kraxel@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-gy0-f174.google.com ([209.85.160.174]:48945 "EHLO
	mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932145Ab1KGOjP (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 7 Nov 2011 09:39:15 -0500
Received: by gyc15 with SMTP id 15so4223585gyc.19
        for <kvm@vger.kernel.org>; Mon, 07 Nov 2011 06:39:15 -0800 (PST)
In-Reply-To: <4EB7EC4A.90607@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/07/2011 08:33 AM, Gerd Hoffmann wrote:
> On 11/07/11 15:17, Avi Kivity wrote:
>> On 11/07/2011 01:00 PM, Gerd Hoffmann wrote:
>>> This patch removes the code lines which set the subsystem id for the
>>> emulated ac97 card to 8086:0000.  Due to the device id being zero the
>>> subsystem id isn't vaild anyway.  With the patch applied the sound card
>>> gets the default qemu subsystem id (1af4:1100) instead.
>>
>> This a guest ABI change.  Do we want -M support for it?
>
> Given that the old subsystem id isn't valid I'd say no unless someone
> comes up with a good reason.

Agreed.

Regards,

Anthony Liguori

>
> cheers,
>    Gerd
>
>