From: Avi Kivity <avi@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1.0] ac97: don't override the pci subsystem id
Date: Mon, 07 Nov 2011 16:42:42 +0200 [thread overview]
Message-ID: <4EB7EE62.7070805@redhat.com> (raw)
In-Reply-To: <4EB7EC4A.90607@redhat.com>
On 11/07/2011 04:33 PM, Gerd Hoffmann wrote:
> On 11/07/11 15:17, Avi Kivity wrote:
> > On 11/07/2011 01:00 PM, Gerd Hoffmann wrote:
> >> This patch removes the code lines which set the subsystem id for the
> >> emulated ac97 card to 8086:0000. Due to the device id being zero the
> >> subsystem id isn't vaild anyway. With the patch applied the sound card
> >> gets the default qemu subsystem id (1af4:1100) instead.
> >
> > This a guest ABI change. Do we want -M support for it?
>
> Given that the old subsystem id isn't valid I'd say no unless someone
> comes up with a good reason.
Do we know that Windows won't complain about it?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-07 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 11:00 [PATCH 1.0] ac97: don't override the pci subsystem id Gerd Hoffmann
2011-11-07 14:17 ` Avi Kivity
2011-11-07 14:33 ` Gerd Hoffmann
2011-11-07 14:39 ` [Qemu-devel] " Anthony Liguori
2011-11-07 14:42 ` Avi Kivity [this message]
2011-11-07 14:44 ` Anthony Liguori
2011-11-07 14:50 ` Avi Kivity
2011-11-07 14:53 ` Anthony Liguori
2011-11-07 15:00 ` Avi Kivity
2011-11-07 15:10 ` [Qemu-devel] " Gerd Hoffmann
2011-11-07 15:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB7EE62.7070805@redhat.com \
--to=avi@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox