From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id Date: Mon, 07 Nov 2011 08:44:45 -0600 Message-ID: <4EB7EEDD.4090604@codemonkey.ws> References: <1320663634-29453-1-git-send-email-kraxel@redhat.com> <4EB7E896.9010108@redhat.com> <4EB7EC4A.90607@redhat.com> <4EB7EE62.7070805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , Takashi Iwai , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:43345 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932639Ab1KGOos (ORCPT ); Mon, 7 Nov 2011 09:44:48 -0500 Received: by mail-gy0-f174.google.com with SMTP id 15so4228690gyc.19 for ; Mon, 07 Nov 2011 06:44:48 -0800 (PST) In-Reply-To: <4EB7EE62.7070805@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/07/2011 08:42 AM, Avi Kivity wrote: > On 11/07/2011 04:33 PM, Gerd Hoffmann wrote: >> On 11/07/11 15:17, Avi Kivity wrote: >>> On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: >>>> This patch removes the code lines which set the subsystem id for the >>>> emulated ac97 card to 8086:0000. Due to the device id being zero the >>>> subsystem id isn't vaild anyway. With the patch applied the sound card >>>> gets the default qemu subsystem id (1af4:1100) instead. >>> >>> This a guest ABI change. Do we want -M support for it? >> >> Given that the old subsystem id isn't valid I'd say no unless someone >> comes up with a good reason. > > Do we know that Windows won't complain about it? I thought the original motivation for the default subsystem ids was that some Windows test suite was explicitly complaining about having invalid subsystem ids? Regards, Anthony Liguori >