From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH] i386: derive '-cpu host' from KVM_GET_SUPPORTED_CPUID Date: Wed, 09 Nov 2011 20:00:26 +0200 Message-ID: <4EBABFBA.5070106@redhat.com> References: <1320846276-19659-1-git-send-email-avi@redhat.com> <4EBABEC4.2080303@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48910 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602Ab1KISAd (ORCPT ); Wed, 9 Nov 2011 13:00:33 -0500 In-Reply-To: <4EBABEC4.2080303@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 11/09/2011 07:56 PM, Anthony Liguori wrote: > On 11/09/2011 07:44 AM, Avi Kivity wrote: >> The fact that a host cpu supports a feature doesn't mean that QEMU >> and KVM >> will also support it, yet -cpuid host brings host features wholesale. >> >> We need to whitelist each feature separately to make sure we support it. >> This patch adds KVM whitelisting (by simply using >> KVM_GET_SUPPORTED_CPUID >> instead of the CPUID instruction). >> >> Signed-off-by: Avi Kivity > > This seems like a 1.0 candidate, yes? There is a distinct possibility this will uncover bugs in kvm's KVM_GET_SUPPORTED_CPUID. Those won't be qemu bugs, so I think it's good for 1.0. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.