From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces
 qcow2 corruptions
Date: Fri, 11 Nov 2011 14:38:09 -0600
Message-ID: <4EBD87B1.5050800@codemonkey.ws>
References: <4EBAAA68.10801@redhat.com>	<4EBAACAF.4080407@codemonkey.ws>	<4EBAB236.2060409@redhat.com>	<4EBAB9FA.3070601@codemonkey.ws>	<4EBB919B.7040605@redhat.com>	<4EBC1792.3030004@codemonkey.ws>	<4EBC4260.1090405@codemonkey.ws>	<4EBCF5DA.1000605@redhat.com>	<4EBD2B4F.5040409@codemonkey.ws>	<4EBD3145.3050409@redhat.com> <4EBD32C1.6000805@codemonkey.ws> <4EBD34C3.1050608@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>,
	KVM mailing list <kvm@vger.kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"libvir-list@redhat.com" <libvir-list@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	QEMU devel <qemu-devel@nongnu.org>,
	Juan Jose Quintela Carreira <quintela@redhat.com>,
	Avi Kivity <avi@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-iy0-f174.google.com ([209.85.210.174]:54815 "EHLO
	mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754515Ab1KKUiO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 11 Nov 2011 15:38:14 -0500
Received: by iage36 with SMTP id e36so4502057iag.19
        for <kvm@vger.kernel.org>; Fri, 11 Nov 2011 12:38:14 -0800 (PST)
In-Reply-To: <4EBD34C3.1050608@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/11/2011 08:44 AM, Kevin Wolf wrote:
> Am 11.11.2011 15:35, schrieb Anthony Liguori:
>> This is not a bug fix, this is a new feature.  We're long past feature freeze.
>> It's not a simple and obvious fix either.  It only partially fixes the problem
>> and introduces other problems.  It's not a good candidate for making an
>> exception at this stage in the release.
>>
>> [1] http://mid.gmane.org/cover.1294150511.git.quintela@redhat.com
>
> Then please send a fix that fails migration with non-raw images. Not
> breaking images silently during migration is critical for 1.0, IMO.

I sent a quick series.  If you want to do things different for the blocker layer 
like add a field to BlockDriver to indicate whether migration is supported and 
register the blocker in the core code, feel free to do that.

Regards,

Anthony Liguori

>
> Kevin
>