From: Avi Kivity <avi@redhat.com>
To: David Evensky <evensky@dancer.ca.sandia.gov>
Cc: Sasha Levin <levinsasha928@gmail.com>,
Pekka Enberg <penberg@kernel.org>,
kvm@vger.kernel.org
Subject: Re: kvm-tools: can't seem to set guest_mac and KVM_GET_SUPPORTED_CPUID failed.
Date: Thu, 17 Nov 2011 19:30:20 +0200 [thread overview]
Message-ID: <4EC544AC.2080801@redhat.com> (raw)
In-Reply-To: <20111117171327.GE25489@dancer.ca.sandia.gov>
On 11/17/2011 07:13 PM, David Evensky wrote:
> func 0000000d ind 00000001 flags 00000001 -> 00000001 00000000 00000000 00000000
> func 80000001 ind 00000000 flags 00000000 -> 00000000 00000000 00000001 28100800
> func 0000000d ind 00000003 flags 00000001 -> 00000000 00000000 00000000 00000000
> func 0000000d ind 00000004 flags 00000001 -> 00000000 00000000 00000000 00000000
> func 0000000d ind 00000005 flags 00000001 -> 00000000 00000000 00000000 00000000
Leaf 0xd handling is broken in 3.0:
case 0xd: {
int i;
entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
for (i = 1; *nent < maxnent && i < 64; ++i) {
if (entry[i].eax == 0)
continue;
do_cpuid_1_ent(&entry[i], function, i);
entry[i].flags |=
KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
++*nent;
}
break;
}
We check entry[i].eax before we compute it. 3.2 is fine, so it's only a
matter of backports.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-17 17:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 0:42 kvm-tools: can't seem to set guest_mac and KVM_GET_SUPPORTED_CPUID failed David Evensky
2011-11-17 6:07 ` Sasha Levin
2011-11-17 6:53 ` Pekka Enberg
2011-11-17 6:56 ` Sasha Levin
2011-11-17 9:04 ` Avi Kivity
2011-11-17 10:08 ` Sasha Levin
2011-11-17 15:38 ` David Evensky
2011-11-17 15:43 ` Sasha Levin
2011-11-17 15:50 ` David Evensky
2011-11-17 15:52 ` Sasha Levin
2011-11-17 15:53 ` Avi Kivity
2011-11-17 16:12 ` David Evensky
2011-11-17 16:20 ` Sasha Levin
2011-11-17 16:20 ` Avi Kivity
2011-11-17 16:29 ` David Evensky
2011-11-17 16:49 ` Avi Kivity
2011-11-17 17:13 ` David Evensky
2011-11-17 17:30 ` Avi Kivity [this message]
2011-11-17 15:55 ` David Evensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC544AC.2080801@redhat.com \
--to=avi@redhat.com \
--cc=evensky@dancer.ca.sandia.gov \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox