From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm-tools: can't seem to set guest_mac and KVM_GET_SUPPORTED_CPUID failed. Date: Thu, 17 Nov 2011 19:30:20 +0200 Message-ID: <4EC544AC.2080801@redhat.com> References: <1321512998.4221.7.camel@lappy> <20111117153833.GA5915@dancer.ca.sandia.gov> <1321544629.8010.9.camel@lappy> <20111117155000.GB5915@dancer.ca.sandia.gov> <1321545120.8010.10.camel@lappy> <4EC52E0E.1000502@redhat.com> <20111117161200.GB25489@dancer.ca.sandia.gov> <4EC53451.5070209@redhat.com> <20111117162959.GC25489@dancer.ca.sandia.gov> <4EC53B0C.4090300@redhat.com> <20111117171327.GE25489@dancer.ca.sandia.gov> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Sasha Levin , Pekka Enberg , kvm@vger.kernel.org To: David Evensky Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26221 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757052Ab1KQRbI (ORCPT ); Thu, 17 Nov 2011 12:31:08 -0500 In-Reply-To: <20111117171327.GE25489@dancer.ca.sandia.gov> Sender: kvm-owner@vger.kernel.org List-ID: On 11/17/2011 07:13 PM, David Evensky wrote: > func 0000000d ind 00000001 flags 00000001 -> 00000001 00000000 00000000 00000000 > func 80000001 ind 00000000 flags 00000000 -> 00000000 00000000 00000001 28100800 > func 0000000d ind 00000003 flags 00000001 -> 00000000 00000000 00000000 00000000 > func 0000000d ind 00000004 flags 00000001 -> 00000000 00000000 00000000 00000000 > func 0000000d ind 00000005 flags 00000001 -> 00000000 00000000 00000000 00000000 Leaf 0xd handling is broken in 3.0: case 0xd: { int i; entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX; for (i = 1; *nent < maxnent && i < 64; ++i) { if (entry[i].eax == 0) continue; do_cpuid_1_ent(&entry[i], function, i); entry[i].flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX; ++*nent; } break; } We check entry[i].eax before we compute it. 3.2 is fine, so it's only a matter of backports. -- error compiling committee.c: too many arguments to function