From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: [PATCH v2 6/6] KVM: introduce a table to map slot id to index in memslots arry
Date: Fri, 18 Nov 2011 17:20:26 +0800 [thread overview]
Message-ID: <4EC6235A.90705@linux.vnet.ibm.com> (raw)
In-Reply-To: <4EC6226B.3080408@linux.vnet.ibm.com>
The operation of getting dirty log is frequency When framebuffer-based
displays are used(for example, Xwindow), so, we introduce a mapping table
to speed up id_to_memslot()
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
include/linux/kvm_host.h | 13 +++++++------
virt/kvm/kvm_main.c | 7 ++++++-
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 83b396a..fbf66eb 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -238,6 +238,8 @@ struct kvm_irq_routing_table {};
struct kvm_memslots {
u64 generation;
struct kvm_memory_slot memslots[KVM_MEM_SLOTS_NUM];
+ /* The mapping table from slot id to the index in memslots[]. */
+ int id_to_index[KVM_MEM_SLOTS_NUM];
};
struct kvm {
@@ -340,14 +342,13 @@ static inline struct kvm_memslots *kvm_memslots(struct kvm *kvm)
static inline struct kvm_memory_slot *
id_to_memslot(struct kvm_memslots *slots, int id)
{
- int i;
+ int index = slots->id_to_index[id];
+ struct kvm_memory_slot *slot;
- for (i = 0; i < KVM_MEM_SLOTS_NUM; i++)
- if (slots->memslots[i].id == id)
- return &slots->memslots[i];
+ slot = &slots->memslots[index];
- WARN_ON(1);
- return NULL;
+ WARN_ON(slot->id != id);
+ return slot;
}
#define HPA_MSB ((sizeof(hpa_t) * 8) - 1)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 9425e3a..0dad825 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -446,7 +446,7 @@ static void kvm_init_memslots_id(struct kvm *kvm)
struct kvm_memslots *slots = kvm->memslots;
for (i = 0; i < KVM_MEM_SLOTS_NUM; i++)
- slots->memslots[i].id = i;
+ slots->id_to_index[i] = slots->memslots[i].id = i;
}
static struct kvm *kvm_create_vm(void)
@@ -675,8 +675,13 @@ static int cmp_memslot(const void *slot1, const void *slot2)
*/
static void sort_memslots(struct kvm_memslots *slots)
{
+ int i;
+
sort(slots->memslots, KVM_MEM_SLOTS_NUM,
sizeof(struct kvm_memory_slot), cmp_memslot, NULL);
+
+ for (i = 0; i < KVM_MEM_SLOTS_NUM; i++)
+ slots->id_to_index[slots->memslots[i].id] = i;
}
void update_memslots(struct kvm_memslots *slots, struct kvm_memory_slot *new)
--
1.7.7.1
next prev parent reply other threads:[~2011-11-18 9:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 9:16 [PATCH v2 0/6] KVM: optimize memslots searching Xiao Guangrong
2011-11-18 9:17 ` [PATCH v2 1/6] KVM: introduce KVM_MEM_SLOTS_NUM macro Xiao Guangrong
2011-11-18 9:17 ` [PATCH v2 2/6] KVM: introduce update_memslots function Xiao Guangrong
2011-11-18 9:18 ` [PATCH v2 3/6] KVM: introduce kvm_for_each_memslot macro Xiao Guangrong
2011-11-20 11:21 ` Avi Kivity
2011-11-21 0:54 ` Takuya Yoshikawa
2011-11-21 8:34 ` Avi Kivity
2011-11-21 8:40 ` Takuya Yoshikawa
2011-11-21 8:43 ` Xiao Guangrong
2011-11-21 3:33 ` Xiao Guangrong
2011-11-18 9:19 ` [PATCH v2 4/6] KVM: introduce id_to_memslot function Xiao Guangrong
2011-11-18 9:19 ` [PATCH v2 5/6] KVM: sort memslots by its size and use line search Xiao Guangrong
2011-11-20 11:26 ` Avi Kivity
2011-11-20 11:27 ` Avi Kivity
2011-11-21 3:48 ` Xiao Guangrong
2011-11-18 9:20 ` Xiao Guangrong [this message]
2011-11-18 9:45 ` [PATCH v2 6/6] KVM: introduce a table to map slot id to index in memslots arry Sasha Levin
2011-11-18 10:03 ` Xiao Guangrong
2011-11-18 9:41 ` [PATCH v2 0/6] KVM: optimize memslots searching Sasha Levin
2011-11-18 9:56 ` Xiao Guangrong
2011-11-20 11:29 ` Avi Kivity
2011-11-20 12:12 ` Avi Kivity
2011-11-21 3:54 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC6235A.90705@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).