From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 0/6] KVM: optimize memslots searching
Date: Sun, 20 Nov 2011 13:29:15 +0200 [thread overview]
Message-ID: <4EC8E48B.9080204@redhat.com> (raw)
In-Reply-To: <4EC6226B.3080408@linux.vnet.ibm.com>
On 11/18/2011 11:16 AM, Xiao Guangrong wrote:
> This is the more work base on my v1 patchset which is posted some months ago,
> it can be found at:
> https://lkml.org/lkml/2011/2/22/68
>
> Change log:
> - sort memslots base on its size and do the line search instead of binary
> search base on gfn, it is from Avi's idea.
> - in order to reduce cache footprint, memslots are sorted in the array of
> kvm->memslots->memslots[] and introduce a table to map slot id to index in
> the array
>
> There is the performance result:
>
> autotest for RHEL.6.1 setup/boot/reboot/shutdown(average):
> ept=1: before: 449.5 after: 447.8
> ept=0: before: 532.7 after: 529.8
>
> kernbench(average):
> ept=1: before: 127.94 after: 126.98
> ept=0: before: 196.85 after: 189.66
Looks good, had a couple of comments but they're really minor.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-20 11:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 9:16 [PATCH v2 0/6] KVM: optimize memslots searching Xiao Guangrong
2011-11-18 9:17 ` [PATCH v2 1/6] KVM: introduce KVM_MEM_SLOTS_NUM macro Xiao Guangrong
2011-11-18 9:17 ` [PATCH v2 2/6] KVM: introduce update_memslots function Xiao Guangrong
2011-11-18 9:18 ` [PATCH v2 3/6] KVM: introduce kvm_for_each_memslot macro Xiao Guangrong
2011-11-20 11:21 ` Avi Kivity
2011-11-21 0:54 ` Takuya Yoshikawa
2011-11-21 8:34 ` Avi Kivity
2011-11-21 8:40 ` Takuya Yoshikawa
2011-11-21 8:43 ` Xiao Guangrong
2011-11-21 3:33 ` Xiao Guangrong
2011-11-18 9:19 ` [PATCH v2 4/6] KVM: introduce id_to_memslot function Xiao Guangrong
2011-11-18 9:19 ` [PATCH v2 5/6] KVM: sort memslots by its size and use line search Xiao Guangrong
2011-11-20 11:26 ` Avi Kivity
2011-11-20 11:27 ` Avi Kivity
2011-11-21 3:48 ` Xiao Guangrong
2011-11-18 9:20 ` [PATCH v2 6/6] KVM: introduce a table to map slot id to index in memslots arry Xiao Guangrong
2011-11-18 9:45 ` Sasha Levin
2011-11-18 10:03 ` Xiao Guangrong
2011-11-18 9:41 ` [PATCH v2 0/6] KVM: optimize memslots searching Sasha Levin
2011-11-18 9:56 ` Xiao Guangrong
2011-11-20 11:29 ` Avi Kivity [this message]
2011-11-20 12:12 ` Avi Kivity
2011-11-21 3:54 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC8E48B.9080204@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).