From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] KVM: introduce kvm_for_each_memslot macro
Date: Mon, 21 Nov 2011 11:33:41 +0800 [thread overview]
Message-ID: <4EC9C695.3060907@linux.vnet.ibm.com> (raw)
In-Reply-To: <4EC8E2D3.1080804@redhat.com>
On 11/20/2011 07:21 PM, Avi Kivity wrote:
> On 11/18/2011 11:18 AM, Xiao Guangrong wrote:
>> index bb8728e..10524c0 100644
>> --- a/include/linux/kvm_host.h
>> +++ b/include/linux/kvm_host.h
>> @@ -307,6 +307,10 @@ static inline struct kvm_vcpu *kvm_get_vcpu(struct kvm *kvm, int i)
>> (vcpup = kvm_get_vcpu(kvm, idx)) != NULL; \
>> idx++)
>>
>> +#define kvm_for_each_memslot(slots, memslot, i) \
>> + for (i = 0; i < (slots)->nmemslots && \
>> + ({ memslot = &(slots)->memslots[i]; 1; }); i++)
>> +
>>
>
> Statement expression not needed, you can use the comma operator:
>
> i < (slots)->nmemslots && (memslot = @(slots)->memslots[i], true)
>
> or even
>
> memslot = &(slots)->memslots[i], i < (slots)->nmemslots
>
> or just kill i and make memslot the loop variable.
>
Good, will fix it in the next version, thanks!
next prev parent reply other threads:[~2011-11-21 3:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 9:16 [PATCH v2 0/6] KVM: optimize memslots searching Xiao Guangrong
2011-11-18 9:17 ` [PATCH v2 1/6] KVM: introduce KVM_MEM_SLOTS_NUM macro Xiao Guangrong
2011-11-18 9:17 ` [PATCH v2 2/6] KVM: introduce update_memslots function Xiao Guangrong
2011-11-18 9:18 ` [PATCH v2 3/6] KVM: introduce kvm_for_each_memslot macro Xiao Guangrong
2011-11-20 11:21 ` Avi Kivity
2011-11-21 0:54 ` Takuya Yoshikawa
2011-11-21 8:34 ` Avi Kivity
2011-11-21 8:40 ` Takuya Yoshikawa
2011-11-21 8:43 ` Xiao Guangrong
2011-11-21 3:33 ` Xiao Guangrong [this message]
2011-11-18 9:19 ` [PATCH v2 4/6] KVM: introduce id_to_memslot function Xiao Guangrong
2011-11-18 9:19 ` [PATCH v2 5/6] KVM: sort memslots by its size and use line search Xiao Guangrong
2011-11-20 11:26 ` Avi Kivity
2011-11-20 11:27 ` Avi Kivity
2011-11-21 3:48 ` Xiao Guangrong
2011-11-18 9:20 ` [PATCH v2 6/6] KVM: introduce a table to map slot id to index in memslots arry Xiao Guangrong
2011-11-18 9:45 ` Sasha Levin
2011-11-18 10:03 ` Xiao Guangrong
2011-11-18 9:41 ` [PATCH v2 0/6] KVM: optimize memslots searching Sasha Levin
2011-11-18 9:56 ` Xiao Guangrong
2011-11-20 11:29 ` Avi Kivity
2011-11-20 12:12 ` Avi Kivity
2011-11-21 3:54 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC9C695.3060907@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).