Re: [PATCH v2 0/6] KVM: optimize memslots searching

[Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>]

On 11/20/2011 08:12 PM, Avi Kivity wrote:

> On 11/20/2011 01:29 PM, Avi Kivity wrote:
>> On 11/18/2011 11:16 AM, Xiao Guangrong wrote:
>>> This is the more work base on my v1 patchset which is posted some months ago,
>>> it can be found at:
>>> https://lkml.org/lkml/2011/2/22/68
>>>
>>> Change log:
>>> - sort memslots base on its size and do the line search instead of binary
>>>   search base on gfn, it is from Avi's idea.
>>> - in order to reduce cache footprint, memslots are sorted in the array of
>>>   kvm->memslots->memslots[] and introduce a table to map slot id to index in
>>>   the array
>>>
>>> There is the performance result:
>>>
>>> autotest for RHEL.6.1 setup/boot/reboot/shutdown(average):
>>> ept=1:	before: 449.5	after: 447.8
>>> ept=0:	before: 532.7	after: 529.8
>>>
>>> kernbench(average):
>>> ept=1:	before: 127.94	after: 126.98
>>> ept=0:	before: 196.85	after: 189.66
>>
>> Looks good, had a couple of comments but they're really minor.
>>
> 
> btw, this patchset touches a lot of common code.  Did you crossbuild for
> other kvm archs?
> 


No :-), but i will build cross compilation environment and test it next time,
thanks!